Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project’s packaging and CI by migrating from setup.py/requirements files to a PEP 621-style pyproject.toml (Hatchling build), and updates CI workflows to install the package via extras.
Changes:
- Replace legacy packaging (
setup.py,MANIFEST.in,requirements/*) withpyproject.tomlusing Hatchling and optional dependency groups. - Update GitHub Actions workflows to install
.[test]viauvand adjust build/publish to usepython -m build. - Minor internal tweak in
BedSetPlotsfield checking (BedSetPlots.model_fields).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Removed legacy setuptools setup in favor of pyproject.toml. |
| requirements/requirements-*.txt | Removed requirements files; dependencies moved into pyproject.toml. |
| pyproject.toml | Added PEP 621 project metadata, dependencies, optional dependency groups, and tool configs. |
| bbconf/modules/bedsets.py | Use class-level BedSetPlots.model_fields for field membership check. |
| bbconf/_version.py | Removed legacy version module. |
| bbconf/init.py | Stops importing/exporting __version__. |
| MANIFEST.in | Removed legacy manifest file. |
| .pre-commit-config.yaml | Removed pre-commit configuration. |
| .github/workflows/run-pytest.yml | Installs .[test] via uv and updates action versions. |
| .github/workflows/cli-coverage.yml | Installs .[test] via uv and updates action versions. |
| .github/workflows/python-publish.yml | Builds with python -m build and publishes with trusted publishing. |
| .github/workflows/black.yml | Replaces Black action with Ruff lint/format checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Modernize - phase 4 - types update
Modernize - phase 6 - docstrings
# Conflicts: # bbconf/_version.py # requirements/requirements-all.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
TODO:
__version__.pyfile