feat: add dev-best-practices skill, deprecate databricks-config#298
Open
michael-berk wants to merge 6 commits intodatabricks-solutions:mainfrom
Open
feat: add dev-best-practices skill, deprecate databricks-config#298michael-berk wants to merge 6 commits intodatabricks-solutions:mainfrom
michael-berk wants to merge 6 commits intodatabricks-solutions:mainfrom
Conversation
Adds a new skill distilled from the FDE Technical Playbook (Niall Turbitt, AI FDE) covering engineering best practices for Databricks FDE engagements: Git workflow, code quality, software architecture, Databricks platform patterns, CI/CD, testing philosophy, and production handoff. - CREATE databricks-skills/databricks-fde-playbook/ (6 files): SKILL.md, 1-foundations-and-setup.md, 2-code-quality.md, 3-architecture.md, 4-databricks-platform.md, 5-productionization.md - DELETE databricks-skills/databricks-config/ - MCP-specific workspace switching with no standalone value; CLI auth covered by FDE playbook - UPDATE databricks-python-sdk and databricks-asset-bundles SKILL.md with cross-references to the new FDE playbook skill Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
michael-berk
commented
Mar 12, 2026
…e FDE references - Rename skill directory and update name/description in SKILL.md - Generalize all FDE-specific language in sub-files - Update cross-references in databricks-asset-bundles, databricks-python-sdk, databricks-zerobus-ingest - Update app.yaml ENABLED_SKILLS and databricks-skills/README.md - Fix stale databricks-config references from deprecation Co-authored-by: Isaac
michael-berk
changed the title
Author
|
Synced over slack and should be ready to merge. If you stamp, would appreciate a merge as well. Thanks a bunch! |
dustinvannoy-db
requested changes
Mar 14, 2026
Collaborator
dustinvannoy-db
left a comment
dustinvannoy-db
left a comment
There was a problem hiding this comment.
Suggesting we remove some of the more team specific and internal flow references. Have you tested that this will still help you with auth? I think maybe we should modify databricks-config and leave it as an option to manually invoke, which I could help with those changes.
databricks-skills/dev-best-practices/1-foundations-and-setup.md
Outdated
Show resolved
Hide resolved
databricks-skills/dev-best-practices/1-foundations-and-setup.md
Outdated
Show resolved
Hide resolved
databricks-skills/dev-best-practices/1-foundations-and-setup.md
Outdated
Show resolved
Hide resolved
databricks-skills/dev-best-practices/1-foundations-and-setup.md
Outdated
Show resolved
Hide resolved
- Remove internal onboarding checklist (not appropriate for shared repo) - Remove Glean reference in IDE setup (not available to all users) - Replace Mac-specific brew CLI install with generic dependency note - Increase Ruff line length from 88 to 120 to match project convention - Remove dev-best-practices cross-ref from databricks-asset-bundles Co-authored-by: Isaac
- Remove engagement/consulting-specific framing (customer, engagement, FDE) throughout dev-best-practices in favor of neutral language - Remove internal reusable-ip-ai repo link from 3-architecture.md - Rename "Engagement Exit Checklist" → "Project Handoff Checklist" - Generalize Google Drive/TPM, LucidChart, Slack, JIRA references - Restore databricks-config/SKILL.md as a minimal auth/profile setup skill (per Dustin Vannoy's review comment on PR databricks-solutions#298) - Re-add databricks-config to README under Development & Deployment Co-authored-by: Isaac
…cross-reference Co-authored-by: Isaac
Author
Great feedback thanks. I reverted deprecation of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev-best-practicesskill with 5 comprehensive reference docs covering foundations, code quality, architecture, Databricks platform,and productionization
databricks-configskill (content superseded by the new skill)databricks-asset-bundles,databricks-python-sdk, anddatabricks-zerobus-ingestskillsTest plan
dev-best-practicesSKILL.md trigger conditions are correctdatabricks-configdeprecation is clean (no stale references)This pull request was AI-assisted by Isaac.