Skip local file validation in config sync#4648
Merged
ilyakuz-db merged 8 commits intomainfrom Mar 9, 2026
Merged
Conversation
ilyakuz-db
requested review from
andrewnester,
anton-107,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 11cc936
18 interesting tests: 7 SKIP, 6 RECOVERED, 5 flaky
Top 27 slowest tests (at least 2 minutes):
|
ilyakuz-db
changed the title
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
Mar 6, 2026
| remoteRoot string | ||
|
|
||
| // skipLocalFileValidation makes path translation tolerant of missing local files. | ||
| // When set, paths are translated without verifying files exist on the local filesystem. |
Contributor
There was a problem hiding this comment.
It would be nice to add context when this happens: when user modifies pipeline remotely which is then synced via config-sync option.
| nb, _, err := notebook.DetectWithFS(t.b.SyncRoot, localRelPath) | ||
| if errors.Is(err, fs.ErrNotExist) { | ||
| if t.skipLocalFileValidation { | ||
| localRelPathNoExt := strings.TrimSuffix(localRelPath, path.Ext(localRelPath)) |
Contributor
There was a problem hiding this comment.
question -- do we need to run DetectWithFS in this case, do we want to catch other errors? Anything in particular? Or we do we just calculate the path and proceed without any possibility of error?
Contributor
Author
There was a problem hiding this comment.
Good question, probably we can skip validation completely here
…li into skip-validation-config-sync
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Skip local file validation in config-remote-sync
Why
Use case:
The issue occurs because we have a validation step that checks for the existence of local files during the path translation phase. We do need path translation because config sync needs fully resolved paths to compare it with fields from remote object, but validation is not necessary in this case
Tests