Fix: check constraints enforced config param prior to applying#1343
Open
colin-rogers-dbt wants to merge 4 commits intodatabricks:mainfrom
Open
Fix: check constraints enforced config param prior to applying#1343colin-rogers-dbt wants to merge 4 commits intodatabricks:mainfrom
colin-rogers-dbt wants to merge 4 commits intodatabricks:mainfrom
Conversation
colin-rogers-dbt
requested review from
benc-db,
sd-db and
tejassp-db
as code owners
2 tasks
sd-db
changed the title
sd-db
reviewed
Mar 6, 2026
Collaborator
sd-db
left a comment
sd-db
left a comment
There was a problem hiding this comment.
One minor comment, we apply constraints in the MV flow as well. From databricks docs this seems purely informational but the behaviour exists and there is even a test to check for this test_create_materialized_view_with_comment_and_constraints. We should apply the guard here + update tests for completeness.
| {#- Incremental constraint application requires information_schema access (see fetch_*_constraints macros) -#} | ||
| {% if constraints and not target_relation.is_hive_metastore() %} | ||
| {% set contract_config = config.get('contract') %} | ||
| {% if constraints and contract_config.enforced and not target_relation.is_hive_metastore() %} |
Collaborator
There was a problem hiding this comment.
let us add a null guard here - {% if constraints and contract_config and contract_config.enforced and not target_relation.is_hive_metastore() %}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1342
Description
Add constraint enforcement checks.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.