fix: add missing optimize() call to table v2 materialization#1345
Merged
Conversation
Coverage report
This PR does not seem to contain any modification to coverable code. |
The table v2 materialization path was missing the optimize() call that exists in the v1 path, incremental v1 path, and incremental v2 path. When use_materialization_v2 was enabled with liquid_clustered_by, zorder, or auto_liquid_cluster configured, OPTIMIZE would not run after table creation/replacement. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sd-db
force-pushed
the
sd-db/fix/table-v2-missing-optimize
branch
from
df9d147 to
e28f5b7
Compare
benc-db
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
table.sqlwas missing theoptimize()call that exists in all other materialization paths (table v1, incremental v1, incremental v2)use_materialization_v2was enabled withliquid_clustered_by,zorder, orauto_liquid_clusterconfigured,OPTIMIZEwould not run after table creation/replacementTest plan
TestTableV2LiquidClusteringpasses — confirmsOPTIMIZEruns in the v2 path