Repository navigation
Submit Isaac feedback asynchronously in Smart Router sessions - #1214
Merged
Merged
Conversation
JJ27
changed the title
JJ27
marked this pull request as ready for review
October 21, 2026 01:53
JJ27
force-pushed
the
JJ27/isaac-feedback-async
branch
from
October 21, 2026 06:29
0f83c50 to
ae68959
Compare
JJ27
changed the title
lilly-luo
reviewed
Oct 21, 2026
lilly-luo
reviewed
Oct 21, 2026
JJ27
force-pushed
the
JJ27/isaac-feedback-async
branch
from
October 21, 2026 18:10
68d2573 to
c840559
Compare
lilly-luo
reviewed
Oct 21, 2026
lilly-luo
reviewed
Oct 21, 2026
JJ27
changed the title
Collaborator
|
it's still a little slow to run the cmd but the async works and is an improvement to before Screen.Recording.2026-10-21.at.3.15.57.PM.mov |
lilly-luo
approved these changes
Oct 21, 2026
lilly-luo
reviewed
Oct 21, 2026
lilly-luo
approved these changes
Oct 21, 2026
lilly-luo
left a comment
lilly-luo
left a comment
Collaborator
There was a problem hiding this comment.
can you address this before merge pls: https://github.com/databricks/unity-gateway/pull/1214/changes#r4340955358
JJ27
force-pushed
the
JJ27/isaac-feedback-async
branch
from
October 21, 2026 20:53
55e2138 to
b7f292d
Compare
JJ27
changed the title
Collaborator
|
lgtm now! Screen.Recording.2026-10-21.at.10.12.10.PM.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you change, and why?
/isaac-feedbackshould let Smart Router users keep working while feedback is captured and uploaded, matching/smart-router off.In Claude sessions launched with Smart Router and
ISAAC_SMART_ROUTER_FEEDBACKenabled, both commands share the native form and background submission. Enter closes the form and shows the sending message and evidence feedback ID; one existing Isaac CLI invocation captures and uploads the report. The native flow remains available after turning routing off in that session. Sessions launched without Smart Router retain the existing feedback skill.Smart-routing reports pin the original task's native message ID and freeze the caller's session and routing controls, so a later prompt or toggle cannot change the selected task or settings. Empty sessions remain without a task. Transcript and file evidence reflects background capture time and available file history.
The form asks for missing category/text; an explicit category and message submit directly. Other reports stay text-only. Failed uploads offer a retry of the saved snapshot; failed captures ask for a new submission. Explicit inspection/preview requests retain the existing skill. This uses the existing routing plugin and Isaac CLI, with no extra launcher path or background worker. Keep Claude open until submission completes.
How do you know it works?