Repository navigation
change outlier.shape = NA for outliers = FALSE - #980
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/datacarpentry/R-ecology-lesson/compare/md-outputs..md-outputs-PR-980 The following changes were observed in the rendered markdown documents: What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2026-09-22 21:47:47 +0000 |
Co-authored-by: Hugo Gruson <hugo.gruson@protonmail.com>
Bisaloo
left a comment
There was a problem hiding this comment.
LGTM.
@datacarpentry/r-ecology-lesson-maintainers, could we have a second review if you're available please?
If not, I'll go ahead and merge this in the coming weeks.
|
Yes, I can review the PR in the next two days. I'm catching up after being away at a conference. Thanks for all your work on this one! |
estregger
left a comment
There was a problem hiding this comment.
Thanks for updating the lesson to match current practice, @josenino95 and @Bisaloo
This PR is complete and can be merged.
Auto-generated via `{sandpaper}`
Source : ce9749c
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-09-28 13:41:34 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : cae1678
Branch : main
Author : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time : 2026-09-28 13:12:33 +0000
Message : change outlier.shape = NA for outliers = FALSE (#980)
Auto-generated via `{sandpaper}`
Source : ce9749c
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-09-28 13:41:34 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : cae1678
Branch : main
Author : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time : 2026-09-28 13:12:33 +0000
Message : change outlier.shape = NA for outliers = FALSE (#980)
Auto-generated via `{sandpaper}`
Source : ce9749c
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-09-28 13:41:34 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : cae1678
Branch : main
Author : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time : 2026-09-28 13:12:33 +0000
Message : change outlier.shape = NA for outliers = FALSE (#980)
If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Closes #979
Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
Explained in #979. But basically, in the ggplot episode, I changed all references from
outlier.shape = NAtooutliers = FALSE. I briefly read the text around the changes I made and I think I didn't brake anything in the sense of non-sensical text or references to the previous use ofoutlier.shape = NAIf any relevant discussions have taken place elsewhere, please provide links to these.
See the issue linked above