Skip to content

change outlier.shape = NA for outliers = FALSE - #980

Merged
Bisaloo merged 2 commits into
datacarpentry:mainfrom
josenino95:outliers-change
Sep 28, 2026
Merged

Bisaloo merged 2 commits into
datacarpentry:mainfrom
josenino95:outliers-change

Conversation

@josenino95

Copy link
Copy Markdown
Contributor

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Closes #979

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
Explained in #979. But basically, in the ggplot episode, I changed all references from outlier.shape = NA to outliers = FALSE. I briefly read the text around the changes I made and I think I didn't brake anything in the sense of non-sensical text or references to the previous use of outlier.shape = NA

If any relevant discussions have taken place elsewhere, please provide links to these.
See the issue linked above

@github-actions

github-actions Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/datacarpentry/R-ecology-lesson/compare/md-outputs..md-outputs-PR-980

The following changes were observed in the rendered markdown documents:

 ...isualizing-ggplot-rendered-boxplot-jitter-1.png | Bin 683705 -> 687063 bytes
 ...ualizing-ggplot-rendered-boxplot-outliers-1.png | Bin 684315 -> 673553 bytes
 ...lot-rendered-customizing-challenge-answer-1.png | Bin 792695 -> 800692 bytes
 ...visualizing-ggplot-rendered-element-blank-1.png | Bin 660190 -> 663396 bytes
 fig/visualizing-ggplot-rendered-facet-wrap-1.png   | Bin 567851 -> 573761 bytes
 fig/visualizing-ggplot-rendered-fill-na-1.png      | Bin 647602 -> 648606 bytes
 fig/visualizing-ggplot-rendered-geom-color-1.png   | Bin 667221 -> 670792 bytes
 fig/visualizing-ggplot-rendered-global-color-1.png | Bin 666903 -> 663409 bytes
 fig/visualizing-ggplot-rendered-labels-1.png       | Bin 809507 -> 814261 bytes
 ...visualizing-ggplot-rendered-legend-remove-1.png | Bin 822831 -> 823937 bytes
 ...isualizing-ggplot-rendered-reverse-layers-1.png | Bin 516126 -> 515042 bytes
 fig/visualizing-ggplot-rendered-text-size-1.png    | Bin 661941 -> 662951 bytes
 fig/visualizing-ggplot-rendered-theme-bw-1.png     | Bin 673524 -> 671800 bytes
 ...sualizing-ggplot-rendered-unnamed-chunk-1-1.png | Bin 648933 -> 650574 bytes
 ...g-ggplot-rendered-violin-challenge-answer-1.png | Bin 585818 -> 585642 bytes
 ...ggplot-rendered-violin-challenge-answer-2-1.png | Bin 582250 -> 581855 bytes
 md5sum.txt                                         |   2 +-
 visualizing-ggplot.md                              |  16 ++++++++--------
 18 files changed, 9 insertions(+), 9 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2026-09-22 21:47:47 +0000

Comment thread episodes/visualizing-ggplot.Rmd Resolved
Co-authored-by: Hugo Gruson <hugo.gruson@protonmail.com>
@josenino95
josenino95 requested a review from Bisaloo September 22, 2026 21:32
github-actions Bot pushed a commit that referenced this pull request Sep 22, 2026

@Bisaloo Bisaloo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@datacarpentry/r-ecology-lesson-maintainers, could we have a second review if you're available please?

If not, I'll go ahead and merge this in the coming weeks.

@estregger estregger self-assigned this Sep 25, 2026
@estregger

Copy link
Copy Markdown
Contributor

Yes, I can review the PR in the next two days. I'm catching up after being away at a conference.

Thanks for all your work on this one!

@estregger estregger left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the lesson to match current practice, @josenino95 and @Bisaloo

This PR is complete and can be merged.

@Bisaloo
Bisaloo merged commit cae1678 into datacarpentry:main Sep 28, 2026
5 checks passed
github-actions Bot pushed a commit that referenced this pull request Sep 28, 2026
Auto-generated via `{sandpaper}`
Source  : cae1678
Branch  : main
Author  : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time    : 2026-09-28 13:12:33 +0000
Message : change outlier.shape = NA for outliers = FALSE (#980)
github-actions Bot pushed a commit that referenced this pull request Sep 28, 2026
Auto-generated via `{sandpaper}`
Source  : ce9749c
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-09-28 13:41:34 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : cae1678
Branch  : main
Author  : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time    : 2026-09-28 13:12:33 +0000
Message : change outlier.shape = NA for outliers = FALSE (#980)
github-actions Bot pushed a commit that referenced this pull request Sep 29, 2026
Auto-generated via `{sandpaper}`
Source  : ce9749c
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-09-28 13:41:34 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : cae1678
Branch  : main
Author  : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time    : 2026-09-28 13:12:33 +0000
Message : change outlier.shape = NA for outliers = FALSE (#980)
github-actions Bot pushed a commit that referenced this pull request Oct 6, 2026
Auto-generated via `{sandpaper}`
Source  : ce9749c
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-09-28 13:41:34 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : cae1678
Branch  : main
Author  : Jose Niño <72319858+josenino95@users.noreply.github.com>
Time    : 2026-09-28 13:12:33 +0000
Message : change outlier.shape = NA for outliers = FALSE (#980)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing the way we teach how to remove outliers

3 participants