Fix(Evaluator): Coalesce null values in arithmetic functions#81
Open
arnaudfnr wants to merge 5 commits into
Open
Fix(Evaluator): Coalesce null values in arithmetic functions#81arnaudfnr wants to merge 5 commits into
arnaudfnr wants to merge 5 commits into
Conversation
Cabanon
reviewed
Apr 29, 2026
| expr = coalesce(lhs.expr, 0) - coalesce(rhs.expr, 0) | ||
| case "/": | ||
| expr = lhs.expr / rhs.expr | ||
| expr = coalesce(lhs.expr, 0) / coalesce(rhs.expr, 0) |
Collaborator
There was a problem hiding this comment.
division par 0 pas ouf il faut que tu fasses un case pour que ce soit null en cas de division par 0
Collaborator
Author
There was a problem hiding this comment.
Ok j'ajoute un case
Cabanon
reviewed
Apr 29, 2026
| expr = coalesce(lhs.expr, 0) / coalesce(rhs.expr, 0) | ||
| case "*": | ||
| expr = lhs.expr * rhs.expr | ||
| expr = coalesce(lhs.expr, 0) * coalesce(rhs.expr, 0) |
Collaborator
There was a problem hiding this comment.
on veut vraiment qu'une multiplication par null fasse 0 ?
Collaborator
Author
There was a problem hiding this comment.
Je remplace par 1
Collaborator
There was a problem hiding this comment.
en fait j'en sais rien, peut-être que 0 c'est bien
Cabanon
reviewed
Apr 29, 2026
| expr = coalesce(lhs.expr, 0) * coalesce(rhs.expr, 0) | ||
| case "^": | ||
| expr = func.pow(lhs.expr, rhs.expr) | ||
| expr = func.pow(coalesce(lhs.expr, 0), coalesce(rhs.expr, 1)) |
Collaborator
Author
There was a problem hiding this comment.
Pour la puissance null² = 0 pour moi
Collaborator
There was a problem hiding this comment.
En fait j'ai un doute sur le fait qu'on devrait toucher au power, autant division et multiplication c'est intuitif autant le power peut-être qu'il faut laisser fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.