feat(search): type aware custom filters#1067
Merged
ThibaudDauce merged 4 commits intomainfrom May 4, 2026
Merged
Conversation
ThibaudDauce
approved these changes
May 4, 2026
Contributor
ThibaudDauce
left a comment
ThibaudDauce
left a comment
There was a problem hiding this comment.
Not a fan of the duplication between the v-if and the useSearchFilter but I don't have a better solution right now :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ecolabdata/ecospheres#1089
This introduces a new config parameter
typeKeysthat lets downstream say if a custom filter is shared across types or not. If it's not shared, the background search for other types is skipped. This behaves similarly to native filters.