Skip to content

fix(datapacks): CAT-2450 remove invalid prefix from dataHubRole - #205

Merged
javabrett merged 2 commits into
mainfrom
javabrett/CAT-2450-prefixed-roles
Jun 22, 2026
Merged

fix(datapacks): CAT-2450 remove invalid prefix from dataHubRole#205
javabrett merged 2 commits into
mainfrom
javabrett/CAT-2450-prefixed-roles

Conversation

@javabrett

Copy link
Copy Markdown
Contributor

Similar to CAT-2446 where dataHubRole was being exported with a prefix. Roles are internal/fixed/system names, so this created a dangling role, which broke the users page when an impacted user record was loaded.

Similar to CAT-2446 where dataHubRole was being exported with a
prefix. Roles are internal/fixed/system names, so this created a
dangling role, which broke the users page when an impacted user
record was loaded.
@javabrett javabrett self-assigned this Jun 17, 2026
@vercel

vercel Bot commented Jun 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
datahub-docs-archive Ignored Ignored Jun 22, 2026 11:44pm

Request Review

@otto-the-otter-bot

Copy link
Copy Markdown

The fix looks correct — removing the invalid prefix from dataHubRole is the right call! 🙌

One thing worth checking: does the datapack version need to be bumped?

If there's an index.json for this pack, the version field should be incremented so existing DataHub deployments re-download the updated content. Without a version bump, installations that have already cached this pack will silently skip the fix (since the system compares cached vs. current version before deciding to re-fetch).

If dataHubRole is also defined in the core OSS bootstrap_mcps/roles.yaml, the corresponding version in bootstrap_mcps.yaml should be incremented as well — the roles file even has a comment explicitly calling this out as a required step.

@otto-the-otter-bot

Copy link
Copy Markdown

Version Bump Required 🔢

After digging into the specifics, this PR modifies datapacks/showcase-ecommerce/02-data.json (stripping invalid b2fd91. prefixes from dataHubRole URNs), so the datapack version needs a bump.

What to Update

datapacks/showcase-ecommerce/index.json

  • Current: "version": "3"
  • Should be: "version": "4"

Without this bump, existing DataHub deployments that have already cached version 3 of this datapack will silently skip the fix — the system compares the cached version against the current index.json before deciding whether to re-fetch content.

OSS Bootstrap MCPs

The core OSS bootstrap_mcps/roles.yaml was not modified by this PR, so no version bump is needed there.

@javabrett
javabrett merged commit dccfe29 into main Jun 22, 2026
3 checks passed
@javabrett
javabrett deleted the javabrett/CAT-2450-prefixed-roles branch June 22, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants