Skip to content

a button to clean all filters + actions column - #1975

Draft
DianaAliabieva wants to merge 1 commit into
datalab-org:mainfrom
Matgenix:da/clear_all_filters
Draft

DianaAliabieva wants to merge 1 commit into
datalab-org:mainfrom
Matgenix:da/clear_all_filters

Conversation

@DianaAliabieva

@DianaAliabieva DianaAliabieva commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

Adding a button to clean all filters when multiple ones are selected.
image
image
image

image image image

Here is the "new"column with actions. If there is more than 3 action you will have a list of others actions in a drop-diwn list.
(for no the data there was a random one).
All actions works according to the code.

@codecov

codecov Bot commented Aug 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.48%. Comparing base (ddb057c) to head (f0f729e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1975   +/-   ##
=======================================
  Coverage   82.48%   82.48%           
=======================================
  Files          91       91           
  Lines        8782     8782           
=======================================
  Hits         7244     7244           
  Misses       1538     1538           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidwaroquiers

Copy link
Copy Markdown
Member

Note to @ml-evs, we'd see the contextual actions for each row in the same "column" as the column in which this clear filter is right now.

@ml-evs ml-evs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just mentioning again, could this be based on #1914 please? Otherwise looks good!

@DianaAliabieva
DianaAliabieva changed the base branch from main to bc/refactor-dynamicdatatable August 24, 2026 09:25
@DianaAliabieva

Copy link
Copy Markdown
Contributor Author

Just mentioning again, could this be based on #1914 please? Otherwise looks good!

Hello, the PR is ready for the check and now it is based on #1914

@davidwaroquiers
davidwaroquiers marked this pull request as draft September 1, 2026 10:10
@ml-evs
ml-evs changed the base branch from bc/refactor-dynamicdatatable to main September 13, 2026 21:52
…atalab-org#1914)

Adapts the clear-filters column/button to the new columns-driven filter
setup from datalab-org#1914: extracts default-filters construction into
getDefaultFilters() so it can be reused both on created() and when
clearing, adds hasActiveFilters, and updates the 4 component tests for
the extra header column.
@DianaAliabieva
DianaAliabieva marked this pull request as ready for review October 8, 2026 07:46
@DianaAliabieva DianaAliabieva changed the title adding a button to clean all filters a button to clean all filters + actions column Oct 8, 2026
@DianaAliabieva
DianaAliabieva marked this pull request as draft October 8, 2026 12:17

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants