Repository navigation
Option to hide collections in webapp - #2113
Open
davidwaroquiers wants to merge 4 commits into
Open
davidwaroquiers wants to merge 4 commits into
davidwaroquiers wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2113 +/- ##
=======================================
Coverage 82.48% 82.48%
=======================================
Files 91 91
Lines 8782 8782
=======================================
Hits 7244 7244
Misses 1538 1538 🚀 New features to boost your workflow:
|
Member
Author
|
This is ready for review @ml-evs I've also opened #2153 that is the "same" except that it also disables the backend. I let you decide which one is best. This one is obviously smaller (no backend changes), while the other one is somehow "complete" for the disabling of the collections and has a few more changes related to backend. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially solves #1965
This removes (read: hides them conditionally to the VUE_APP_HIDE_COLLECTIONS environment option) all collections related views/options. As already explained in #1965, access rights with collections can be misleading. This PR does not remove collection-related backend parts (database, end points etc ...).
With the soon to be included tags features, collections somehow become an alternative (although with some slightly different behavior) to tags. Both features are still compatible with each other for those who would require/prefer to have both.