Repository navigation
Add admin endpoints and UI for deleting and expunging user accounts - #2158
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2158 +/- ##
==========================================
+ Coverage 82.48% 82.62% +0.14%
==========================================
Files 91 91
Lines 8782 8860 +78
==========================================
+ Hits 7244 7321 +77
- Misses 1538 1539 +1
🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/tombstone-user-accounts
|
| Run status |
|
| Run duration | 04m 50s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
275
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
force-pushed
the
ml-evs/tombstone-user-accounts
branch
from
September 30, 2026 18:37
9e80f31 to
61edddd
Compare
Member
|
Happy to review this if you want @ml-evs. Just assign me in case. |
Member
Author
Sure, I think this is now safe after the XSS fixes which sanitize display names, but I'll also double check myself. |
davidwaroquiers
requested changes
Oct 5, 2026
davidwaroquiers
left a comment
Member
There was a problem hiding this comment.
Hi @ml-evs
Very nice work and useful in general thx! I left a couple of comments, some are "cosmetic" (not in the UI/UX sense), some I think are worth checking/addressing.
ml-evs
force-pushed
the
ml-evs/tombstone-user-accounts
branch
from
October 11, 2026 17:01
456e940 to
7f2eba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #478 by:
DELETE /users/<user_id>endpoint that lets admins delete an accountThis PR also:
/users/endpoint by date created with newest first by default