Skip to content

Add ability for block plugins to provide custom vue components - #2192

Draft
ml-evs wants to merge 4 commits into
mainfrom
ml-evs/block-vue
Draft

ml-evs wants to merge 4 commits into
mainfrom
ml-evs/block-vue

Conversation

@ml-evs

@ml-evs ml-evs commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

This PR also includes #1742, which removed core plugins (chat, XPS, in situ) which were the ones that needed custom Vue in the first place. It adds a similar mechanism as is used for the custom vue components for item types, which will now also be detected during invoke dev.install and copied to the correct place. In order to use custom components, the plugin must also include a short index.js that appends the data block to the block registry for the app at build time.

Follow up PR will let this plugin also include its own npm dependencies. I might decide to split this PR into just the plugins then a separate PR with the removal.

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.48%. Comparing base (ddb057c) to head (31fbb76).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2192   +/-   ##
=======================================
  Coverage   82.48%   82.48%           
=======================================
  Files          91       91           
  Lines        8782     8782           
=======================================
  Hits         7244     7244           
  Misses       1538     1538           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress

cypress Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

datalab    Run #6162

Run Properties:  status check passed Passed #6162  •  git commit 1c92cdedb6 ℹ️: Merge 0f369ff4a68d74fb34872987f4ecc916452edb2d into ddb057c9effb193eeec531c23ead...
Project datalab
Branch Review ml-evs/block-vue
Run status status check passed Passed #6162
Run duration 17m 37s
Commit git commit 1c92cdedb6 ℹ️: Merge 0f369ff4a68d74fb34872987f4ecc916452edb2d into ddb057c9effb193eeec531c23ead...
Committer Matthew Evans
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 202
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

ml-evs added 2 commits October 5, 2026 10:20
Move chat block into temporary local plugin within repository

Remove stipulations on newer projects

Move chat block into temporary local plugin within repository

Remove insitu Vue components

Bump uv lock

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant