VSB/Incorrect data when browsing by author

[Paurikova2]

Problem description

In Browse by Author, the results include not only author names but also authority ID, all sorted alphabetically.

[Paurikova2]

Originally, SimpleORCIDAuthority.java was used. However, due to issues with ORCID API requests, the getLabel method in CachingOrcidRestConnector consistently returned null. Once the ORCID integration is resolved, this workaround will no longer be necessary.

[Copilot]

Pull request overview

Adds a new ChoiceAuthority implementation backed by the metadata_value table to ensure “Browse by Author” displays author labels (not authority IDs), and introduces a DAO/service query to fetch metadata values by authority + language.

Changes:

• Added MetadataValueBasedChoiceAuthority to resolve labels and matches from MetadataValue records.
• Added findByAuthorityAndLanguage() to MetadataValueDAO/MetadataValueService (+ implementation).
• Added unit tests and updated test local.cfg to wire the authority plugin.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
dspace-api/src/main/java/org/dspace/content/authority/MetadataValueBasedChoiceAuthority.java	New ChoiceAuthority implementation for label/match lookup from metadata_value.
dspace-api/src/main/java/org/dspace/content/service/MetadataValueService.java	Adds service API to query by authority + language.
dspace-api/src/main/java/org/dspace/content/MetadataValueServiceImpl.java	Implements new service method by delegating to DAO.
dspace-api/src/main/java/org/dspace/content/dao/MetadataValueDAO.java	Adds DAO method signature for authority + language lookup.
dspace-api/src/main/java/org/dspace/content/dao/impl/MetadataValueDAOImpl.java	Implements JPQL query for authority + language lookup.
dspace-api/src/test/java/org/dspace/content/authority/MetadataValueBasedChoiceAuthorityTest.java	Adds unit tests for new authority behavior.
dspace-api/src/test/data/dspaceFolder/config/local.cfg	Wires the new authority plugin for tests.

[Copilot]

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

[Paurikova2]

@Kasinhou please test this.

[milanmajchrak]

Missing @author

[milanmajchrak]

what...

[milanmajchrak]

@Paurikova2 When I uncommented it browsing by author is not working.. it still shows UUID.
ORCID feature, must be allowed.