[Port to dtq-dev] Improve back navigation logic in ItemComponent

[kosarko]

Port of ufal#80 by @amadulhaxxani to dtq-dev.

[Copilot]

Pull request overview

This pull request is a port of ufal#80 to the dtq-dev branch, improving the back navigation logic in ItemComponent by adding session storage support for the previous URL. This enhancement allows the back button to persist across page refreshes and navigation scenarios where the previous URL might not be available from the RouteService.

Changes:

• Added session storage support to remember the previous URL when navigating to an item page
• Implemented generic session storage helper methods in RouteService for storing and retrieving URLs
• Updated navigation logic to fall back to session storage when the current route doesn't provide a valid previous URL

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/app/core/services/route.service.ts	Added storeUrlInSession and getUrlFromSession methods with SSR-compatible checks for session storage access
src/app/item-page/simple/item-types/shared/item.component.ts	Updated ngOnInit to use session storage fallback, simplified back() method to use stored URL, added pickAllowedPrevious helper
src/app/item-page/simple/item-types/shared/item.component.spec.ts	Added ngOnInit() call in test to ensure proper initialization before assertions
src/app/shared/testing/route-service.stub.ts	Added stubs for storeUrlInSession, getUrlFromSession, and clearUrlFromSession methods
src/app/item-page/simple/item-types/untyped-item/untyped-item.component.spec.ts	Added stubs for new session storage methods in local mock route service
src/app/item-page/simple/item-types/publication/publication.component.spec.ts	Added stubs for new session storage methods in local mock route service

Comments suppressed due to low confidence (1)

src/app/item-page/simple/item-types/shared/item.component.spec.ts:519

• The tests in the 'back to results' section don't cover the new session storage fallback behavior introduced in this PR. Consider adding tests for scenarios such as: (1) when getPreviousUrl returns a non-matching URL but getUrlFromSession returns a valid stored URL, the back button should be shown; (2) when storeUrlInSession is called with a valid URL, it should be retrievable later; (3) when the back() method is called, it should navigate to the stored URL. These tests would help verify the core functionality of this PR.

    it('should hide back button',() => {
      spyOn(mockRouteService, 'getPreviousUrl').and.returnValue(observableOf('/item'));
      comp.ngOnInit();
      comp.showBackButton.subscribe((val) => {
        expect(val).toBeFalse();
      });
    });
    it('should show back button for search', () => {
      spyOn(mockRouteService, 'getPreviousUrl').and.returnValue(observableOf(searchUrl));
      comp.ngOnInit();
      comp.showBackButton.subscribe((val) => {
        expect(val).toBeTrue();
      });
    });
    it('should show back button for browse', () => {
      spyOn(mockRouteService, 'getPreviousUrl').and.returnValue(observableOf(browseUrl));
      comp.ngOnInit();
      comp.showBackButton.subscribe((val) => {
        expect(val).toBeTrue();
      });
    });
    it('should show back button for recent submissions', () => {
      spyOn(mockRouteService, 'getPreviousUrl').and.returnValue(observableOf(recentSubmissionsUrl));
      comp.ngOnInit();
      comp.showBackButton.subscribe((val) => {
        expect(val).toBeTrue();
      });
    });

[milanmajchrak]

@amadulhaxxani thank you for the fix. I've tested it and found out one bug.
How to reproduce:

1. Go to the collection Digital Humanities -> LINDAT / CLARIAH-CZ ->LINDAT / CLARIAH-CZ DH Data
2. Select the first Item: you should see a Back to results button
3. Go to the home page
4. Select one item from the What's New section: You should see the Back to results button again
5. BUG: Click to the Back to results: You will be redirected to the Search results of the Digital Humanities -> LINDAT / CLARIAH-CZ ->LINDAT / CLARIAH-CZ DH Data and not to the home page.

[milanmajchrak]

There is a bug I've described in the comment

[amadulhaxxani]

@milanmajchrak
I will fix it

[milanmajchrak]

@milanmajchrak I will fix it

Thank you!