Skip to content

UFAL/Fix: generate correct curl download URLs using backend handle endpoint #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
milanmajchrak wants to merge 6 commits into
base: dtq-dev
Choose a base branch
from
Open

UFAL/Fix: generate correct curl download URLs using backend handle endpoint #1215

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
745f396
fix: generate correct curl download URLs using backend handle endpoint
milanmajchrak Feb 20, 2026
7b9a8f6
Fixed formatting of the file names
milanmajchrak Feb 20, 2026
07b0ee1
fix: use -o with real filename to avoid percent-encoded names from cu…
milanmajchrak Feb 20, 2026
eba6d17
fix: use curl -OJ with brace expansion for compact download command
milanmajchrak Feb 20, 2026
ee0cc10
Fixed linting error
milanmajchrak Feb 20, 2026
da8baf7
removed duplicates logic
Paurikova2 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/app/item-page/clarin-files-section/clarin-files-section.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Component, Input, OnInit } from '@angular/core';
import { encodeRFC3986URIComponent } from '../../shared/clarin-shared-util';
import { Item } from '../../core/shared/item.model';
import { getAllSucceededRemoteListPayload, getFirstSucceededRemoteDataPayload } from '../../core/shared/operators';
import { getItemPageRoute } from '../item-page-routing-paths';
Expand Down Expand Up @@ -107,10 +108,20 @@ export class ClarinFilesSectionComponent implements OnInit {
return file.name;
});

// Generate curl command for individual bitstream downloads
const baseUrl = `${this.halService.getRootHref()}/bitstream/${this.itemHandle}`;
const fileNamesFormatted = fileNames.map((fileName, index) => `/${index}/${fileName}`).join(',');
this.command = `curl -O ${baseUrl}{${fileNamesFormatted}}`;
// Generate curl command for individual bitstream downloads by handle + filename.
// Uses the backend endpoint: /api/core/bitstreams/handle/{prefix}/{suffix}/{filename}
// -J tells curl to use the filename from the Content-Disposition header (the real name)
// instead of the percent-encoded URL path.
const baseUrl = `${this.halService.getRootHref()}/core/bitstreams/handle/${this.itemHandle}`;
const fileNamesFormatted = fileNames.map(fileName => `/${this.encodeFilenameForUrl(fileName)}`).join(',');
this.command = `curl -OJ "${baseUrl}{${fileNamesFormatted}}"`;
}

/**
* Encode a filename for use in a URL path segment using the shared RFC3986 utility.
*/
private encodeFilenameForUrl(filename: string): string {
return encodeRFC3986URIComponent(filename);
}

loadDownloadZipConfigProperties() {
Expand Down