[WIP] CNDB-17606: Enable FusedPQ, parallel graph writes and FA#2408
Open
ekaterinadimitrova2 wants to merge 6 commits into
Open
[WIP] CNDB-17606: Enable FusedPQ, parallel graph writes and FA#2408ekaterinadimitrova2 wants to merge 6 commits into
ekaterinadimitrova2 wants to merge 6 commits into
Conversation
Checklist before you submit for review
|
| // The test fails if we remove the compressed vector accounting logic from the | ||
| // CassandraDiskAnn.ramBytesUsed() method, proving the fix works correctly. | ||
| long bytesAfterCompaction = (long) getMetricValue(objectName("IndexFileCacheBytes", KEYSPACE, currentTable(), index, "IndexMetrics")); | ||
| System.out.println("KATE: ===== Memory Breakdown ====="); |
Author
There was a problem hiding this comment.
These were for debugging and they wouldn't be committed!
…lel vector graph writing
…ents as I think it was incorrect. To be verified
…he logs as they are internal implementation detail
ekaterinadimitrova2
force-pushed
the
cndb-17606-main
branch
from
0eb7710 to
2cc1a6f
Compare
|
❌ Build ds-cassandra-pr-gate/PR-2408 rejected by Butler5 regressions found Found 5 new test failures
Found 8 known test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the issue
...
This is WIP, I wanted to see the current tests, whether something fails in CI already when we enable things
Also, updated VectorMetricsTest and added some preliminary investigation comments on why
testIndexFileCacheBytesIncludesAllComponentsis not failing after enablingFusedPQ, despite the comment was saying it should.What does this PR fix and why was it fixed
...