Skip to content

CNDB-18059 increase expected disk size to fit on CI#2446

Open
k-rus wants to merge 1 commit into
mainfrom
rf-18059-disk-size-test
Open

CNDB-18059 increase expected disk size to fit on CI#2446
k-rus wants to merge 1 commit into
mainfrom
rf-18059-disk-size-test

Conversation

@k-rus

@k-rus k-rus commented Jun 8, 2026

Copy link
Copy Markdown
Member

What is the issue

Fixes https://github.com/riptano/cndb/issues/18059

During running the SaiDiskSizeTest on CI the actual used disk size was slightly bigger than expected, while no changes were done during the format.

What does this PR fix and why was it fixed

Increases expecting value for the case to fix the test failure and fit the actual size into the expected range.

During running the SaiDiskSizeTest on CI the actual used disk size was
slightly bigger than expected, while no changes were done during the
format.

Increasing expecting value for the case to fix the test failure.
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR and ticket in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the IBM copyright header instead of the Apache License one (no DataStax copyright any longer)

@k-rus

k-rus commented Jun 8, 2026

Copy link
Copy Markdown
Member Author
  • Make sure there is a PR and ticket in the CNDB project updating the Converged Cassandra version

Only test is changed, thus no CNDB's PR.

@plpesvc-ds

Copy link
Copy Markdown

❌ Build ds-cassandra-pr-gate/PR-2446 rejected by Butler


4 regressions found
See build details here


Found 4 new test failures

Test Explanation Runs Upstream
o.a.c.db.compaction.unified.ShardedMultiWriterTest.testShardedCompactionWriter_fiveShards[isReplicaAware=true] (compression) REGRESSION 🔴 0 / 30
o.a.c.index.sai.QueryContextTest.testWideTableScoreOrdered[ec] (compression) REGRESSION 🔴 0 / 30
o.a.c.index.sai.cql.VectorCompaction100dTest.testOneToManyCompaction[version=ec enableNVQ=true] REGRESSION 🔴 0 / 30
o.a.c.index.sai.cql.VectorSiftSmallTest.testSiftSmall[ed false] REGRESSION 🔴 0 / 30

Found 3 known test failures

@k-rus k-rus requested a review from a team June 8, 2026 08:30
@ekaterinadimitrova2

Copy link
Copy Markdown

I am against merging this PR. It doesn't fix the underlying issue. I explained on the GH issue why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants