Skip to content

CNDB-17862 CNDB-16859 Use SinglePartitionReadCommand for index queries#2467

Open
michaelsembwever wants to merge 1 commit into
main-5.0from
mck-cndb-17862-main-5.0
Open

CNDB-17862 CNDB-16859 Use SinglePartitionReadCommand for index queries#2467
michaelsembwever wants to merge 1 commit into
main-5.0from
mck-cndb-17862-main-5.0

Conversation

@michaelsembwever

@michaelsembwever michaelsembwever commented Jun 16, 2026

Copy link
Copy Markdown
Member

https://github.com/riptano/cndb/issues/17862

    Port of CASSANDRA-19968

    Stop transforming single-partition queries using secondary indexes into range commands,
    but use SinglePartitionReadCommand instead, as in not-indexed queries.

    Benefits of single-partition commands are:
    * They use speculative retries, which aren't supported for range queries.
    * They use digest reads, which are benficial for network usage and throughput.
    * Metrics and observability are able to distinguish between single-partition and cluster-wide SAI queries.

forward merges https://github.com/datastax/cassandra/commit/c628d7be0f11e09be981c9f4e46899c636f6df8c

    Port of CASSANDRA-19968

    Stop transforming single-partition queries using secondary indexes into range commands,
    but use SinglePartitionReadCommand instead, as in not-indexed queries.

    Benefits of single-partition commands are:
    * They use speculative retries, which aren't supported for range queries.
    * They use digest reads, which are benficial for network usage and throughput.
    * Metrics and observability are able to distinguish between single-partition and cluster-wide SAI queries.

forward merges c628d7b
@github-actions

Copy link
Copy Markdown

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR and ticket in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the IBM copyright header instead of the Apache License one (no DataStax copyright any longer)

@plpesvc-ds

Copy link
Copy Markdown

❌ Build ds-cassandra-pr-gate/PR-2467 rejected by Butler


50 regressions found
See build details here


Found 50 new test failures

Showing only first 15 new test failures

Test Explanation Runs Upstream
o.a.c.db.PartitionRangeReadCommandCQLTest.testToCQLString (compression) REGRESSION 🔴 0 / 30
o.a.c.db.commitlog.CommitLogSegmentManagerCDCTest.testSegmentFlaggingWithNonblockingOnCreation () NEW 🔴 0 / 30
o.a.c.db.filter.ANNOptionsTest.testParseAndValidate (compression) REGRESSION 🔴 0 / 30
o.a.c.db.filter.IndexHintsTest.testLegacy (compression) REGRESSION 🔴 0 / 30
o.a.c.db.filter.IndexHintsTest.testLegacyIndexWithAllowFiltering (compression) REGRESSION 🔴 0 / 30
o.a.c.db.filter.IndexHintsTest.testLegacyIndexWithoutAllowFiltering (compression) REGRESSION 🔴 0 / 30
o.a.c.db.filter.IndexHintsTest.testMixedIndexImplementations (compression) REGRESSION 🔴 0 / 30
o.a.c.db.filter.IndexHintsTest.testMultipleIndexesOnSameColumnLegacyAndSAI (compression) REGRESSION 🔴 0 / 30
o.a.c.db.filter.IndexHintsTest.testMultipleIndexesPerColumnAndContains (compression) REGRESSION 🔴 0 / 30
o.a.c.db.filter.IndexHintsTest.testMultipleIndexesPerColumnAndMatchEqOnAnalyzer (compression) REGRESSION 🔴 0 / 30
o.a.c.db.filter.IndexHintsTest.testMultipleIndexesPerColumnAndUnsupportedEqOnAnalyzer (compression) REGRESSION 🔴 0 / 30
o.a.c.db.filter.IndexHintsTest.testSAIWithAllowFiltering (compression) REGRESSION 🔴 0 / 30
o.a.c.db.filter.IndexHintsTest.testSAIWithoutAllowFiltering (compression) REGRESSION 🔴 0 / 30
o.a.c.db.guardrails.GuardrailSAIAnnRerankKTest.testSAIAnnRerankKThresholds (compression) REGRESSION 🔴 0 / 30
o.a.c.distributed.test.sai.ANNOptionsDistributedTest.testANNOptionsWithAllDS10 NEW 🔴 0 / 30

Found 4 known test failures

@michaelsembwever

Copy link
Copy Markdown
Member Author

working on test failures…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants