CNDB-16886: Reject BM25 queries in validation when the coordinator is before EC (#2459)#2483
Open
djatnieks wants to merge 1 commit into
Open
CNDB-16886: Reject BM25 queries in validation when the coordinator is before EC (#2459)#2483djatnieks wants to merge 1 commit into
djatnieks wants to merge 1 commit into
Conversation
Member
Author
|
resolved trivial import conflict |
Checklist before you submit for review
|
… before EC (#2459) Reject BM25 queries on `Index.validate(ReadCommand)` if the current index version doesn't support them. That way they would be rejected on the coordinator before execution, which is faster and produces a descriptive error message, rather than the generic per-replica error codes. The replicas still will do their own validation if the query gets past the coordinator.
❌ Build ds-cassandra-pr-gate/PR-2483 rejected by Butler4 regressions found Found 4 new test failuresFound 1 known test failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject BM25 queries on
Index.validate(ReadCommand)if the currentindex version doesn't support them. That way they would be rejected on
the coordinator before execution, which is faster and produces a
descriptive error message, rather than the generic per-replica error
codes. The replicas still will do their own validation if the query gets
past the coordinator.