CNDB-18275: Port CNDB-18238: Update JVector to hotfix regression in recall. The pruning option is ignored and no matter what a user sets pruning will be always pointing to FALSE (#2479)#2485
Open
ekaterinadimitrova2 wants to merge 1 commit into
Conversation
…ecall. The pruning option is ignored and no matter what a user sets pruning will be always pointing to FALSE (#2479) ... 4.0.0-rc.8 has a regression in recall when we run queries with pruning set to true. This is the default behavior in our vector queries - we use pruning. ... This hotfix changes the defaults of pruning being set to False. JVector testing shows that no pruning produces similar latencies but better recall, so this was the simplest way to fix recall in a hotfix release in JVector. The pruning option is ignored and no matter what a user sets pruning will be always pointing to FALSE. NOTE: It is a known issue that currently `VectorCompactionTest` and `VectorSiftSmallTest` are timing out in CI so I reran them locally and they still pass.
Checklist before you submit for review
|
❌ Build ds-cassandra-pr-gate/PR-2485 rejected by Butler3 regressions found Found 3 new test failures
Found 2 known test failures |
pkolaczk
approved these changes
Jun 25, 2026
Author
|
All tests marked as regressions are already known timeouts in CI and the tests pass locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...
4.0.0-rc.8 has a regression in recall when we run queries with pruning set to true. This is the default behavior in our vector queries - we use pruning.
...
This hotfix changes the defaults of pruning being set to False. JVector testing shows that no pruning produces similar latencies but better recall, so this was the simplest way to fix recall in a hotfix release in JVector.
The pruning option is ignored and no matter what a user sets pruning will be always pointing to FALSE.
NOTE: It is a known issue that currently
VectorCompactionTestandVectorSiftSmallTestare timing out in CI so I reran them locally and they still pass.What is the issue
...
What does this PR fix and why was it fixed
...