Skip to content

CNDB-15794: Allow ShardingStats to be propagated in CNDB#2487

Open
lesnik2u wants to merge 2 commits into
mainfrom
CNDB-15794
Open

CNDB-15794: Allow ShardingStats to be propagated in CNDB#2487
lesnik2u wants to merge 2 commits into
mainfrom
CNDB-15794

Conversation

@lesnik2u

@lesnik2u lesnik2u commented Jun 24, 2026

Copy link
Copy Markdown

What is the issue

issue: https://github.com/riptano/cndb/issues/15794
cndb side: https://github.com/riptano/cndb/pull/18289

What does this PR fix and why was it fixed

@lesnik2u lesnik2u self-assigned this Jun 24, 2026
@github-actions

Copy link
Copy Markdown

Checklist before you submit for review

  • This PR adheres to the Definition of Done
  • Make sure there is a PR and ticket in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits
  • All new files should contain the IBM copyright header instead of the Apache License one (no DataStax copyright any longer)

@lesnik2u lesnik2u requested review from blambov and jasonstack June 24, 2026 13:18
* Used by CNDB to propagate pre-computed density from the leader to follower compactor nodes,
* and for testing.
*/
@VisibleForTesting

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the @VisibleForTesting annotation.

@plpesvc-ds

Copy link
Copy Markdown

❌ Build ds-cassandra-pr-gate/PR-2487 rejected by Butler


114 regressions found
See build details here


Found 114 new test failures

Showing only first 15 new test failures

Test Explanation Runs Upstream
o.a.c.db.compaction.CompactionStrategyStatisticsTest.testUnifiedCompactionStrategy_leveled_one_shard_oneBucket_F8 (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.CompactionStrategyStatisticsTest.testUnifiedCompactionStrategy_tiered_twoShards_fiveBuckets_W2 (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testBucketSelectionFives[useDiskBoundaries false] (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testBucketSelectionHalved[useDiskBoundaries true] (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testDropExpiredSSTables3Shards[useDiskBoundaries true] (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testGetBucketsDifferentWsUniqueArena[useDiskBoundaries false] (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testGetNextBackgroundTasksNoParallelization[useDiskBoundaries true] (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testLimitCompactions_noLimiting[useDiskBoundaries true] (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testOverlapSetsWithDuplicatedSSTablesProducesNonDuplicatedAggregatesNone[useDiskBoundaries true] (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testOversizedCompactions_limitingTriggered_maxSpaceOverhead10pct[useDiskBoundaries true] (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testPreserveLayout_W2_947[useDiskBoundaries false] (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testPreserveLayout_W2_947[useDiskBoundaries true] (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testPreserveLayout_WM2_947_128[useDiskBoundaries true] (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testRepairedOneDiskOneBucket_MultipleShards[useDiskBoundaries false] (compression) REGRESSION 🔵🔴 0 / 30
o.a.c.db.compaction.UnifiedCompactionStrategyTest.testRepairedTwoDisksOneBucket_MultipleShards[useDiskBoundaries false] (compression) REGRESSION 🔵🔴 0 / 30

Found 5 known test failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants