CNDB-17983: Redact expressions and orderers in SAI query plan (#2448)#2496
Merged
Conversation
Checklist before you submit for review
|
Author
|
Adjusted imports, other minor 5.0 adaptations. Relocated changes to now removed virtual tables, added toString methods where needed. |
Adds the missing redaction of plan expressions and orderers. Also, refactor toCQLString methods to use a Redaction.[NONE|REDACT] enum.
djatnieks
approved these changes
Jun 30, 2026
| ======= | ||
| * | ||
| * @param builder a consumer to receive a builder for the options to append | ||
| >>>>>>> 4714c43331 (CNDB-13129: Add index hints) |
Member
There was a problem hiding this comment.
Yay - I've been waiting for a change to this class that would clean this up!
Author
There was a problem hiding this comment.
Hah, surprised me when I got there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the missing redaction of plan expressions and orderers.
Also, refactor toCQLString methods to use a Redaction.[NONE|REDACT] enum.