Speed up ivec reads by buffering #584
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiFileDataSourcemakes use ofSiftLoader.readFvecsto read base and query vectors, andSiftLoader.readIvecsto read the provided ground truth. ThereadIvecsfunction is currently quite inefficient due to lack of buffering, disproportionately slowing down the time taken to load the Dataset.This is not so important for
Bench, where the time taken to load the dataset is insignificant compared to the time taken to build the index. However, this becomes quite important when running short-lived programs with pre-created graphs, especially during rapid prototyping.This PR addresses this by adding a
BufferedInputStream, similar to the current implementation ofreadFvecs.Some numbers from my machine based on a dataset with ~2M base vectors and ~50K query vectors illustrates the difference:
0.34s (buffered)
Without buffering, reading the ground truth is ~4x slower than the actual base vectors. With buffering, the ground truth is no longer the bottleneck.