docs: document CONNECTOR_DISCOVERY_ENABLED for Fusion-only / air-gapped deployments#150
docs: document CONNECTOR_DISCOVERY_ENABLED for Fusion-only / air-gapped deployments#150antoniocali wants to merge 2 commits into
Conversation
chore: staging -> master - worker v0.3.6
Surface the new olake-ui config flag through the chart's values.yaml comments and README. No template change is needed since olakeUI.env is already a passthrough; this is purely a discoverability improvement so operators of Fusion-only / air-gapped deployments can find the knob. Companion to datazip-inc/olake-ui#382 and datazip-inc/olake-ui#380.
|
Hi @antoniocali could you please take a pull from the latest Is this feature urgent? We are discussing internally to fix this on both worker and ui side currently. |
Not urgent Let me anyway merge from staging and push to resolve conflicts |
Just to also check, this PRs would make sense on helm only after datazip-inc/olake-ui#382 is closed, since that's where the change for connector-discovery-flag is implemented. |
Summary
Companion to datazip-inc/olake-ui#382, which adds a
CONNECTOR_DISCOVERY_ENABLEDserver flag (and a matchingDEFAULT_CONNECTOR_VERSION) to skip Docker Hub / ECR / GCR queries in Fusion-only and air-gapped deployments (datazip-inc/olake-ui#380).The chart needs no template change to support this —
olakeUI.envis already a passthrough map, so any env var set there is propagated to the UI pod. This PR is purely about discoverability: putting the new knob where operators will actually see it.Changes
helm/olake/values.yaml— add a commented example underolakeUI.envshowing how to disable discovery and pin a default version.helm/olake/README.md— add a "Disabling Connector Discovery (Fusion-only / Air-gapped)" subsection alongside the existing "Private Container Registry" section. Explains the use case (Fusion-only Iceberg maintenance, no CDC) and the registry-rate-limit motivation.Notes
olakego/ui:latest. Suggest merging this after, or after a new UI image is tagged.Test plan
helm lint helm/olake/cleanhelm template ... --set olakeUI.env.CONNECTOR_DISCOVERY_ENABLED=false --set olakeUI.env.DEFAULT_CONNECTOR_VERSION=v0.3.18and confirm both vars appear in the olake-ui Deployment env (they should, sinceolakeUI.envis already passed through via the existingrangeloop)