feat: jobserviceaccount enable by default#173
Merged
Conversation
chore: staging -> master - worker v0.3.6
The other components in this chart (olake-ui, olake-worker, temporal,
postgresql, nfs-server, elasticsearch) all support `podLabels` and
`podAnnotations` value blocks that get merged into
`spec.template.metadata`. The Fusion deployment template was missing
both — its pod-template metadata was hardcoded to the
`app.kubernetes.io/*` labels and the config-checksum annotation,
with no extension point.
This matters for deployments running under K8s admission policies that
require specific labels on pod templates (Gatekeeper, Kyverno,
OPA constraints, etc.). Without a `podLabels` hook, operators either
have to live with the policy warnings or carry parent-chart patches.
Changes mirror the same pattern olake-ui/deployment.yaml already uses:
template:
metadata:
labels:
app.kubernetes.io/name: ...
...
{{- with .Values.fusion.podLabels }}
{{- toYaml . | nindent 8 }}
{{- end }}
annotations:
checksum/fusion-config: ...
{{- with .Values.fusion.podAnnotations }}
{{- toYaml . | nindent 8 }}
{{- end }}
Defaults are `{}` in values.yaml so existing deployments render
byte-identically when neither value is set.
Verified with `helm template`:
- default (no overrides) → unchanged labels/annotations
- `--set fusion.podLabels.foo=bar --set fusion.podAnnotations.alpha=beta`
→ both merged into the rendered deployment
chore: staging -> master (worker v0.3.7, helm v0.0.19)
chore: staging -> master (worker v0.3.8, helm v0.0.20)
chore: staging -> master (olake-helm v0.0.21, olake-worker 0.3.9)
chore: staging -> master (olake-helm v0.0.22)
chore: staging->master (olake-worker v0.3.10, olake-helm v0.0.23)
shubham19may
approved these changes
Jun 25, 2026
shubham19may
pushed a commit
that referenced
this pull request
Jun 25, 2026
* feat(fusion): add podLabels and podAnnotations hooks (#151) The other components in this chart (olake-ui, olake-worker, temporal, postgresql, nfs-server, elasticsearch) all support `podLabels` and `podAnnotations` value blocks that get merged into `spec.template.metadata`. The Fusion deployment template was missing both — its pod-template metadata was hardcoded to the `app.kubernetes.io/*` labels and the config-checksum annotation, with no extension point. This matters for deployments running under K8s admission policies that require specific labels on pod templates (Gatekeeper, Kyverno, OPA constraints, etc.). Without a `podLabels` hook, operators either have to live with the policy warnings or carry parent-chart patches. Changes mirror the same pattern olake-ui/deployment.yaml already uses: template: metadata: labels: app.kubernetes.io/name: ... ... {{- with .Values.fusion.podLabels }} {{- toYaml . | nindent 8 }} {{- end }} annotations: checksum/fusion-config: ... {{- with .Values.fusion.podAnnotations }} {{- toYaml . | nindent 8 }} {{- end }} Defaults are `{}` in values.yaml so existing deployments render byte-identically when neither value is set. Verified with `helm template`: - default (no overrides) → unchanged labels/annotations - `--set fusion.podLabels.foo=bar --set fusion.podAnnotations.alpha=beta` → both merged into the rendered deployment * feat: set service account to true by default --------- Co-authored-by: vikash choudhary <vikash@datazip.io> Co-authored-by: Antonio Davide Calì <antoniodavide.cali@zego.com> Co-authored-by: vishal-datazip <vishal@datazip.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set
jobServiceAccount.create: trueby default.Type of change
How Has This Been Tested?
harbor-secret+ custom annotationimagePullSecrets: []: no panic, activity pod has no pull secretsScreenshots or Recordings
N/A
Related PR's (If Any):
N/A