Skip to content

test: unit-test-reformat.go#936

Merged
vaibhav-datazip merged 14 commits into
stagingfrom
feat/reformtat-unit-test
Jun 9, 2026
Merged

test: unit-test-reformat.go#936
vaibhav-datazip merged 14 commits into
stagingfrom
feat/reformtat-unit-test

Conversation

@saksham-datazip

@saksham-datazip saksham-datazip commented May 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Added unit tests for reformat.go and fixed two bugs in ReformatValue and ReformatBool and removed some dead code from reformat.go
Fixes #929 #643

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Added comprehensive unit tests for reformat.go
  • Verified backward compatibility with updated stateVersion

Screenshots or Recordings

N/A

Documentation

  • Documentation Link: [link to README, olake.io/docs, or olake-docs]
  • N/A (bug fix, refactor, or test changes only)

Related PR's (If Any):

@saksham-datazip saksham-datazip changed the title test/ unit-test-reformat.go test/unit-test-reformat.go May 1, 2026
@saksham-datazip saksham-datazip changed the title test/unit-test-reformat.go test: unit-test-reformat.go May 1, 2026
@saksham-datazip saksham-datazip temporarily deployed to integration_tests May 1, 2026 20:20 — with GitHub Actions Inactive
@saksham-datazip saksham-datazip temporarily deployed to integration_tests May 8, 2026 12:12 — with GitHub Actions Inactive
vaibhav-datazip
vaibhav-datazip reviewed May 12, 2026
View reviewed changes
Comment thread utils/typeutils/reformat.go Outdated
Comment thread utils/typeutils/reformat.go Outdated
Comment thread utils/typeutils/reformat_test.go Outdated
Comment thread utils/typeutils/reformat_test.go Outdated
Comment thread utils/typeutils/reformat_test.go Outdated
Comment thread utils/typeutils/reformat_test.go
Comment thread utils/typeutils/reformat_test.go Outdated
Comment thread utils/typeutils/reformat_test.go
Comment thread utils/typeutils/reformat_test.go
Comment thread utils/typeutils/reformat_test.go
vaibhav-datazip
vaibhav-datazip reviewed Jun 7, 2026
View reviewed changes
Comment thread utils/typeutils/reformat.go Outdated
Comment thread utils/typeutils/reformat_test.go
vaibhav-datazip
vaibhav-datazip reviewed Jun 7, 2026
View reviewed changes
Comment thread utils/typeutils/reformat_test.go
vaibhav-datazip
vaibhav-datazip reviewed Jun 8, 2026
View reviewed changes
Comment thread utils/typeutils/reformat_test.go Outdated
@vaibhav-datazip vaibhav-datazip merged commit e00800f into staging Jun 9, 2026
14 checks passed
@vaibhav-datazip vaibhav-datazip deleted the feat/reformtat-unit-test branch June 9, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaibhav-datazip vaibhav-datazip vaibhav-datazip approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saksham-datazip @vaibhav-datazip