Clear pending promise on rejection in memoized function#5
Open
dbeckham wants to merge 1 commit intodatocms:mainfrom
Open
Clear pending promise on rejection in memoized function#5dbeckham wants to merge 1 commit intodatocms:mainfrom
dbeckham wants to merge 1 commit intodatocms:mainfrom
Conversation
The memoized() function was caching failed promises permanently, causing all subsequent calls to return the same rejected promise. This prevented retries after timeout or rejection errors. Changes: - Added rejection handler to clear 'pending' variable on promise failure - Allows retries after failures instead of permanent failure state - Added tests to cover successful caching, rejection handling, and retry behavior Fixes the issue where workspace initialization timeouts would permanently block all script operations with 'lock timeout' errors until server restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the memoized() function will cache failed promises permanently (until restart), causing all subsequent calls to return the same rejected promise. This prevented retries after timeout or rejection errors.
I discovered this bug while trying to track down odd lock timeout errors I was seeing (reported in #4). This bug was keeping me from being able to troubleshoot the problem because I'd have to restart the MCP server after each failure to clear the lock failure.
Changes:
Fixes the issue where workspace initialization timeouts would permanently block all script operations with 'lock timeout' errors until server restart.