chore: cut 1.0.0 - #49
Merged
Merged
Conversation
Release-As: 1.0.0 release-please will not promote past 0.x on its own, and it was right not to: bump-minor-pre-major kept every breaking change at a minor bump, which is what allowed the API to be curated, split across entry points and moved off the client boundary without burning major versions on a library nobody had built against yet. That work is done, so the flag goes and the footer above asks for the version explicitly. DESIGN.md gains what 1.0.0 actually promises, because a version number is a claim about change and it is worth naming which one. The exported names are the contract, asserted by test in index.test.ts and entryPoints.test.ts. Everything not exported may change in a patch. The CSS class names count too, since the stylesheet is opt-in and people build on the markup. Documented behaviour is behaviour you can rely on. What is not promised — numbers above 2^53, digits outside ASCII, the support-matrix rows nobody has hardware for — is stated rather than implied. Cut after seven rounds of looking for reasons not to. The first six each found something: 66 exports nobody had chosen, declarations that were wrong for CommonJS, two critical ARIA violations in the widget the docs said to copy, a 'use client' banner that broke the server action the examples demonstrated, a load-bearing rule with no test holding it, and grouping that was wrong for every Indian locale. The seventh found nothing, and a deliberate hunt for memory leaks found one uncancelled animation frame that was not one. 1301 tests, 100% coverage on all four metrics, 263 Playwright across six projects and three operating systems, every entry within its size budget. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asks release-please for 1.0.0 via a
Release-As: 1.0.0footer, and removes thepre-major flags that were holding it back.
Why it needed asking
bump-minor-pre-majorkept every breaking change at a minor bump — and it wasright to. That is what allowed the API to be curated from 66 exports to 18,
split across four entry points, and moved off the client boundary without
burning major versions on a library nobody had built against yet.
That work is finished, so the flag goes. Past 1.0.0 a
BREAKING CHANGEfootermeans a major, which is the point of the version.
What 1.0.0 promises
Now written down in DESIGN.md, because a version number is a claim about change:
index.test.tsandentryPoints.test.tsreaching into
dist/build on the markup
nullnever beingNaN, the caret rules, grouping following the localeand the matrix rows nobody has hardware to verify
Branches
Cleaned out first, all verified against merged PRs: two stale remotes and ten
locals deleted.
origin/mainis the only remote branch left.State at the cut
Seven audits. The first six each found something real — 66 exports nobody chose,
declarations wrong for CommonJS, two critical ARIA violations in the widget the
docs told people to copy, a
'use client'banner that broke the documentedserver action, a load-bearing rule with no test, and grouping wrong for every
Indian locale. The seventh found nothing, and a leak hunt found one uncancelled
animation frame that was not a leak.
Merging this produces the release PR for 1.0.0. Merging that one publishes.
🤖 Generated with Claude Code