Skip to content

fix: resolve shim imports from packages outside workspace #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jinjiang wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −1
Open

fix: resolve shim imports from packages outside workspace #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,29 @@ export const nodePolyfills = (options: PolyfillOptions = {}): Plugin => {
...(isEnabled(optionsResolved.globals.process, 'build') ? { process: 'vite-plugin-node-polyfills/shims/process' } : {}),
}

// Create a map of shim import paths to their resolved absolute paths
const shimImportMap = new Map<string, string>()
if (isEnabled(optionsResolved.globals.Buffer, 'build')) {
shimImportMap.set('vite-plugin-node-polyfills/shims/buffer', require.resolve('vite-plugin-node-polyfills/shims/buffer'))
}
if (isEnabled(optionsResolved.globals.global, 'build')) {
shimImportMap.set('vite-plugin-node-polyfills/shims/global', require.resolve('vite-plugin-node-polyfills/shims/global'))
}
if (isEnabled(optionsResolved.globals.process, 'build')) {
shimImportMap.set('vite-plugin-node-polyfills/shims/process', require.resolve('vite-plugin-node-polyfills/shims/process'))
}

// Plugin to resolve shim imports during build
const shimsResolverPlugin = shimImportMap.size > 0 ? {
name: 'vite-plugin-node-polyfills:shims-resolver',
resolveId(source: string) {
if (shimImportMap.has(source)) {
return { id: shimImportMap.get(source)!, external: false }
}
return null
},
} : null

return {
build: {
rollupOptions: {
Expand All @@ -235,7 +258,7 @@ export const nodePolyfills = (options: PolyfillOptions = {}): Plugin => {
...Object.keys(shimsToInject).length > 0
? isRolldownVite
? { inject: shimsToInject }
: { plugins: [inject(shimsToInject)] }
: { plugins: [inject(shimsToInject), ...(shimsResolverPlugin ? [shimsResolverPlugin] : [])] }
: {},
},
},
Expand Down