Open
Conversation
davidpdrsn
reviewed
Jun 29, 2022
| lhs: &Value, | ||
| rhs: &Value, | ||
| config: Config, | ||
| ) -> Result<(), String> |
Owner
There was a problem hiding this comment.
I'm curious if we could use something like Any::downcast_ref instead. Then we wouldn't have to add a whole new function.
Contributor
Author
There was a problem hiding this comment.
Good idea!
I'm trying this:
pub fn assert_json_matches_no_panic<Lhs, Rhs>(
lhs: &Lhs,
rhs: &Rhs,
config: Config,
) -> Result<(), String>
where
Lhs: Serialize + Any,
Rhs: Serialize + Any,
In that case, the lifetime of lhs and rhs is 'static. (https://doc.rust-lang.org/std/any/index.html)
Do you have another idea?
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we already have
Value, we can avoid using theSerializetrait. This allows us:panic!As an alternative, we could also make the following function public: