Continuing the graphdb implementations: class and instance completed.#6
Merged
david-w-t merged 38 commits intodavidwt-com:mainfrom Apr 7, 2026
Merged
Continuing the graphdb implementations: class and instance completed.#6david-w-t merged 38 commits intodavidwt-com:mainfrom
david-w-t merged 38 commits intodavidwt-com:mainfrom
Conversation
Propagate the knowledge graph model from knowledge-graph-database-guide.md into CLAUDE.md, README.md, TASKS.md, and all apps/*/CLAUDE.md files. Expand task 3 into six sub-tasks (3a-3f) with concrete APIs and schemas. Fix stale references to nref_include.erl and incorrect compile commands. Apply corrections to knowledge-graph-database-guide.md: - Flatten relationship record structure (reciprocal is a sibling of value) - Correct instance name attribute description (not globally unique) - Broaden compositional parent label to part-of parent - Fix strata diagram arrow direction (references point upward) - Add Literal Attributes as a third attribute node type - Rename Articulation Principles to Modelling Guidelines - Reorder Instance Inheritance Process steps by priority - Expand Multiple Inheritance section with balanced pitfall guidance - Rename Class to Template in View/Document Derivation table # Conflicts: # CLAUDE.md # TASKS.md # apps/database/CLAUDE.md # apps/dictionary/CLAUDE.md # apps/graphdb/CLAUDE.md
Apply fixes from the current session across all documentation: - Add Literal Attributes as a third attribute node type throughout - Correct inheritance priority order to 4-step explicit list in all files - Update graphdb_attr descriptions to replace 'external name attributes' - Rewrite TASKS.md Session Notes as a status table with restated pending concerns (A-E)
…aph-database-guide Rename middle column of reciprocity examples table from 'Relationship' to 'Type' (the cells contain relationship type names, not relationship labels). Replace editorial summaries in the 1997 and 1999 Sources entries with the actual patent title for all three Noyes patents — all three share the title 'Method for representation of knowledge in a computer as a network database system'; continuation-in-part lineage noted for 5,594,837 and 5,878,406. Marks TASKS.md issues D and E as applied.
…ing; clean up app docs knowledge-graph-database-guide.md: - Add forward-reference under Multiple Inheritance noting that conflict resolution will be provided through a future enhancement to relations; until then local values take priority (item B resolved) - Add Construction Order section (item A, applied earlier this session) TASKS.md: - Full rewrite as a clean public-facing task list - Remove session notes, internal history, applied-correction log, and resume token - Renumber tasks 1-5 (graphdb workers, non-normal start, code_change, old directories, start_phases) apps/graphdb/CLAUDE.md, apps/database/CLAUDE.md: - Replace TASKS.md Alignment sections with concise Remaining Work pointers apps/dictionary/CLAUDE.md: - Fix Files table (remove dict_wkr.erl and dictionary_draft.erl; add dictionary_server.erl and term_server.erl which are the actual files) - Remove Known Bugs section (sfiles bug was fixed; draft file note stale) - Remove TASKS.md Alignment section apps/nref/CLAUDE.md: - Update NYI status task references to new numbering (task 2, task 3) - Remove fixed-bugs list and superseded item CLAUDE.md (root): - Remove TASKS.md Alignment section; replace with Remaining Work pointer - Remove stale TASKS.md item reference from nref_include note
…E.md Clarifies that each graph node has two distinct top-level fields: attribute_value_pairs for non-topological literal/complex values, and relationships for graph-topology arcs. Updates the Erlang record example and adds prose descriptions of both fields.
Deleted Database/, Dictionary/, graphdb/, 'Nref Server/', and seerstone.app — all stale artifacts from the old flat layout, unused by rebar3. Updated TASKS.md (removed completed task 4, synced record structure snippet) and CLAUDE.md (removed note about those directories existing).
Extends the relationship map with an optional attribute_value_pairs field for per-arc metadata (provenance, weights, flags, revisions, time frames). AVPs are asymmetric (each node stores its own), do not inherit, and do not participate in traversal by default; a future traversal-condition mechanism is reserved but not ruled out. Updates guide, CLAUDE.md, and TASKS.md including bootstrap and add_relationship/4 implementation notes.
…r, stale DETS cleanup
…les, updated tree
…art processing order
…nt/AttrRel=29, Child/AttrRel=30)
…ips groups; BFS renumber cascades through levels 4
…nrefs start at 1, target_kind arc annotation
…; attributes and classes grow at runtime
- Root: add ARCHITECTURE.md to dir listing, multi-database architecture section, bootstrap nref quick-reference (nrefs 1-30), set_floor/1 note, graphdb_bootstrap and dictionary wiring in Known Incomplete Areas - apps/graphdb: full rewrite — add graphdb_bootstrap.erl, category node kind, Mnesia record format, multi-DB architecture, updated worker APIs (create_relationship_attribute/3 with target_kind), bootstrap nref table - apps/nref: add set_floor/1 to API (Task 0b, pending), fix task refs - apps/dictionary: add dictionary_server/term_server unwired stub note (Task 8) - apps/database: fix NYI callbacks (return ok, not crash), update Remaining Work
Propagate the knowledge graph model from knowledge-graph-database-guide.md into CLAUDE.md, README.md, TASKS.md, and all apps/*/CLAUDE.md files. Expand task 3 into six sub-tasks (3a-3f) with concrete APIs and schemas. Fix stale references to nref_include.erl and incorrect compile commands. Apply corrections to knowledge-graph-database-guide.md: - Flatten relationship record structure (reciprocal is a sibling of value) - Correct instance name attribute description (not globally unique) - Broaden compositional parent label to part-of parent - Fix strata diagram arrow direction (references point upward) - Add Literal Attributes as a third attribute node type - Rename Articulation Principles to Modelling Guidelines - Reorder Instance Inheritance Process steps by priority - Expand Multiple Inheritance section with balanced pitfall guidance - Rename Class to Template in View/Document Derivation table # Conflicts: # CLAUDE.md # TASKS.md # apps/database/CLAUDE.md # apps/dictionary/CLAUDE.md # apps/graphdb/CLAUDE.md
…aph-database-guide Rename middle column of reciprocity examples table from 'Relationship' to 'Type' (the cells contain relationship type names, not relationship labels). Replace editorial summaries in the 1997 and 1999 Sources entries with the actual patent title for all three Noyes patents — all three share the title 'Method for representation of knowledge in a computer as a network database system'; continuation-in-part lineage noted for 5,594,837 and 5,878,406. Marks TASKS.md issues D and E as applied.
…ing; clean up app docs knowledge-graph-database-guide.md: - Add forward-reference under Multiple Inheritance noting that conflict resolution will be provided through a future enhancement to relations; until then local values take priority (item B resolved) - Add Construction Order section (item A, applied earlier this session) TASKS.md: - Full rewrite as a clean public-facing task list - Remove session notes, internal history, applied-correction log, and resume token - Renumber tasks 1-5 (graphdb workers, non-normal start, code_change, old directories, start_phases) apps/graphdb/CLAUDE.md, apps/database/CLAUDE.md: - Replace TASKS.md Alignment sections with concise Remaining Work pointers apps/dictionary/CLAUDE.md: - Fix Files table (remove dict_wkr.erl and dictionary_draft.erl; add dictionary_server.erl and term_server.erl which are the actual files) - Remove Known Bugs section (sfiles bug was fixed; draft file note stale) - Remove TASKS.md Alignment section apps/nref/CLAUDE.md: - Update NYI status task references to new numbering (task 2, task 3) - Remove fixed-bugs list and superseded item CLAUDE.md (root): - Remove TASKS.md Alignment section; replace with Remaining Work pointer - Remove stale TASKS.md item reference from nref_include note
…nt/AttrRel=29, Child/AttrRel=30)
…ips groups; BFS renumber cascades through levels 4
…trap_file, mnesia dir; remove unused index_path
Called once by graphdb_bootstrap to advance the environment nref counter past the bootstrap range (1-30) to 10000, preventing collisions between pre-assigned and runtime-allocated nrefs.
…and correct bootstrap counts (30 nodes, 29 relationships)
…d bootstrap.terms loader
…in _build/test/ct_scratch/bootstrap_*
…PI, category guard, 28 tests
… tests
Seeds three runtime literal attributes (literal_type, target_kind,
relationship_avp) under the Literals subtree on first startup;
idempotently rediscovers them by name on restart. Provides
create_name_attribute/1, create_literal_attribute/2,
create_relationship_attribute/3, create_relationship_type/1,
get_attribute/1, list_attributes/0, list_relationship_types/0, and
seeded_nrefs/0. Every attribute create writes the node record plus a
compositional parent/child arc pair atomically in one Mnesia
transaction; all get_nref/0 calls happen outside the transaction.
Also: CT suites now tolerate {already_loaded, graphdb} so rebar3 ct
can run graphdb_attr_SUITE, graphdb_bootstrap_SUITE, and
graphdb_mgr_SUITE together. Full suite green: 49 CT + 44 EUnit.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… CT + 11 EUnit tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tance, 23 CT + 7 EUnit tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
It seems prior develop branch commits keep accumulating...will figure this out later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.