Fix unitialized var access on allocation failure#297
Merged
Conversation
Fix two places where we didn't handle allocation failures. While `enif_alloc_resource()` blows up on allocation failure, `enif_alloc()` and `enif_alloc_binary()` don't. During encoder and decoder resource creation if small (a few KB) mallocs fail we could end up calling the resource destructor with some uninitalized flags like `have_buffer`. To prevent this class of errors in the future opt to memset the encoder and decoder structure so new fields in the future are by default 0-initialized. Thanks to @qzhuyan (William) in #296 for pointing this issue out and providing a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two places where we didn't handle allocation failures. While
enif_alloc_resource()blows up on allocation failure,enif_alloc()andenif_alloc_binary()don't. During encoder and decoder resource creation if small (a few KB) mallocs fail we could end up calling the resource destructor with some uninitalized flags likehave_buffer.To prevent this class of errors in the future opt to memset the encoder and decoder structure so new fields in the future are by default 0-initialized.
Thanks to @qzhuyan (William) in #296 for pointing this issue out and providing a fix.