Require Actual Attendees before closing an event - #29
Open
dd32 wants to merge 2 commits into
Open
Conversation
- Show the Actual Attendees field when status is wcpt-scheduled (not just wcpt-closed) so supporters can fill it before closing - Prevent manual transition to wcpt-closed without Actual Attendees filled in - Allow cron auto-close to still work (it auto-fills from CampTix data) - Add admin notice when the validation blocks closing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wcpt-scheduled(previously only shown afterwcpt-closed), so supporters can fill it in before closingwcpt-closedwithout filling in the Actual Attendees countclose_wordcamps_after_event) is not affected - it bypasses this validation since it is not an admin form submission and auto-fills the field from CampTix dataChanges
wordcamp-admin.php: ChangedActual Attendeesvisibility condition fromwcpt-closedonly towcpt-scheduledorwcpt-closed. Added closed-status validation inrequire_complete_meta_to_publish_wordcamp(). Added admin notice Require Actual Attendees before closing an event #5.test-wordcamp-actual-attendees.phpwith 5 tests covering: validation blocks close without attendees, allows close with attendees, does not block cron, field visibility at scheduled/pre-scheduled statuses.Test plan
wcpt-scheduledstatus - verify Actual Attendees field appears$_POSTcontext)Closes WordPress#1603
Generated with Claude Code