Skip to content

Disallow adding/editing localfs integration from ui#340

Merged
ddvk merged 3 commits intoddvk:masterfrom
nemunaire:integration-localfs-ui
Nov 18, 2024
Merged

Disallow adding/editing localfs integration from ui#340
ddvk merged 3 commits intoddvk:masterfrom
nemunaire:integration-localfs-ui

Conversation

@nemunaire
Copy link
Copy Markdown
Collaborator

To follow up #240 (comment), this addresses the possibility of adding or editing localfs directly from the UI.

Instead it shows the content to add/edit in .userprofile:

image

To be able to pass error directly from Go code, I added a convention that errors reported as JSON should be passed to the UI as:

c.AbortWithStatusJSON(http.ErrorStatus, gin.H{"error": err.Error()})

@ddvk
Copy link
Copy Markdown
Owner

ddvk commented Nov 18, 2024

we could add a config variable for allowed root paths for localfs, which would mitigate the issue.

@ddvk ddvk merged commit 3371a3c into ddvk:master Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants