Disallow adding/editing localfs integration from ui#340
Merged
ddvk merged 3 commits intoddvk:masterfrom Nov 18, 2024
Merged
Conversation
Owner
|
we could add a config variable for allowed root paths for localfs, which would mitigate the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To follow up #240 (comment), this addresses the possibility of adding or editing localfs directly from the UI.
Instead it shows the content to add/edit in
.userprofile:To be able to pass error directly from Go code, I added a convention that errors reported as JSON should be passed to the UI as: