Conversation
Tophness
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured out the offline bug, and also why you might not have replicated it.
In firefox there's a variable called network.manage-offline-status that kills local sockets when there's a change to the network adapter.
Setting it to false resolves it, but it's kinda important to keep it at it's default value.
Once I worked out what the root cause was, I found a way around it in the script though.
I've also included the fix for #2253, but since that is pending your feedback, you might have other ideas for those.
If that's the case, you can just cherry pick the offline fix (latest commit) separately.