Skip to content

fix(LLM-6233): Docker CIS compliance rules 4.4 & 4.7 #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JKL98ISR merged 4 commits into from
May 27, 2025
Merged

fix(LLM-6233): Docker CIS compliance rules 4.4 & 4.7 #397

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d713c23
LLM-6233 Fix Docker CIS compliance rule [4.7 Ensure update instructio…
daniilyar-deepchecks May 21, 2025
5ebdc9e
LLM-6233 Fix Docker CIS compliance rule [4.4: Ensure images are scann…
daniilyar-deepchecks May 21, 2025
e514cdd
fixed license versions (added comments & excludes)
DovnarAlexander May 26, 2025
86c07cd
Merge branch 'main' into LLM-6233-base-image
JKL98ISR May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
# along with Deepchecks. If not, see <http://www.gnu.org/licenses/>.
# ----------------------------------------------------------------------------

FROM --platform=$BUILDPLATFORM node:16.15-alpine3.14 AS frontend
FROM --platform=$BUILDPLATFORM node:20.10-alpine3.19 AS frontend

WORKDIR /code

Expand All @@ -26,14 +26,12 @@

FROM ubuntu:22.04

ENV PYTHONUNBUFFERED 1

Check warning on line 29 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Legacy key/value format with whitespace separator should not be used 

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
ENV TZ=Asia/Jerusalem
RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone

RUN echo "Updated on 2 Apr 2024" # Change to force apt to update the cache
RUN apt-get -y update && apt-get -y upgrade

RUN apt-get install -y software-properties-common && add-apt-repository ppa:deadsnakes/ppa && \
RUN set -x && apt-get -qqy update && apt-get install -y software-properties-common && add-apt-repository ppa:deadsnakes/ppa && \
apt install -y git python3.11 python3.11-dev python3.11-distutils curl g++ libpq-dev && \
curl -sS https://bootstrap.pypa.io/get-pip.py | python3.11

Expand All @@ -46,7 +44,7 @@
ARG MIXPANEL_ID
ENV MIXPANEL_ID=$MIXPANEL_ID
# ---
ARG DEEPCHECKS_CI_TOKEN

Check warning on line 47 in Dockerfile

View workflow job for this annotation

GitHub Actions / build

Sensitive data should not be used in the ARG or ENV commands 

SecretsUsedInArgOrEnv: Do not use ARG or ENV instructions for sensitive data (ARG "DEEPCHECKS_CI_TOKEN")
More info: https://docs.docker.com/go/dockerfile/rule/secrets-used-in-arg-or-env/

RUN ln -s /usr/bin/python3.11 /usr/bin/python && python -m pip install -U pip==25.1.1 setuptools==80.9.0 --no-cache-dir
# For ARM arch, ray>2.3.1 uses grpcio==1.51.3 which doesn't has wheel and takes forever to build from source
Expand Down
Loading