Skip to content

revamp protect*#153

Open
shreyasvinaya wants to merge 2 commits intomainfrom
protect_star_update
Open

revamp protect*#153
shreyasvinaya wants to merge 2 commits intomainfrom
protect_star_update

Conversation

@shreyasvinaya
Copy link
Copy Markdown
Collaborator

Description

Fix #(issue)

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

that may need protection, along with ranked protecting group recommendations
for each site.

Request body:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap this to numpy style

protection_state: Optional[ProtectionState] = None) -> tuple[int, str]:
"""Calls the LLM model to predict the next step

Parameters
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not numpy style

# FUNCTIONAL GROUPS DATABASE (55+ SMARTS patterns in 10 categories)
# =============================================================================

FUNCTIONAL_GROUPS = {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move configs to separate files

List of ProtectionSite objects, each representing a site that
could potentially be protected. Returns empty list for invalid SMILES.

Examples
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add usage examples to all non-private functions in this file

} for i, sug in enumerate(suggestions)]


def create_protection_selection(site_info: dict,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add these new functions to the rst docs (don't use AI)

"123456",
"!@#$%^&*()",
" ", # Whitespace only
class TestAtomMapping(unittest.TestCase):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove AI auto-generated tests and clean up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants