Skip to content

draft autosolve#183

Open
redrodeo03 wants to merge 8 commits intomainfrom
autosolve
Open

draft autosolve#183
redrodeo03 wants to merge 8 commits intomainfrom
autosolve

Conversation

@redrodeo03
Copy link
Copy Markdown
Collaborator

@redrodeo03 redrodeo03 commented Mar 27, 2026

Description

Fix #(issue)

image

we still need
cache.py
parse.py
rec_prithvi.py
prithvi.py
llm.py
from src/

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@redrodeo03 redrodeo03 marked this pull request as ready for review April 1, 2026 17:24
@@ -0,0 +1,204 @@
"""Batch and single-molecule retrosynthesis runners.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to algorithms

smiles: str,
*,
llm: str = "anthropic/claude-3-7-sonnet-20250219:adv",
az_model: str = "Pistachio_100+",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate PR we need aizynthfinder


Returns
-------
dict[str, Any]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More details on output format please

from src.utils.job_context import logger as context_logger
from src.utils.parse import format_output

def _run(smiles, **kwargs):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this...

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it a public function; avoid "private" functions

)

stability_flag = str(stability_check)
semaphore = asyncio.Semaphore(max_concurrent)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to document this thoroughly

hallucination_mode, hallucination_classifier,
)

stability_flag = str(stability_check)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this? Document

semaphore = asyncio.Semaphore(max_concurrent)
loop = asyncio.get_running_loop()

async def _process(smi: str) -> dict[str, Any]:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants