Open
Conversation
rbharath
reviewed
Apr 14, 2026
Contributor
rbharath
left a comment
There was a problem hiding this comment.
@ARY2260 Can you do a round of review?
@shreyasvinaya The API feels like it is passing around a lot of parameters in a way that will be hard to maintain. I will think more about how to improve
rbharath
reviewed
Apr 14, 2026
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class ModelSelection: |
Contributor
There was a problem hiding this comment.
Why do we want this data class?
rbharath
reviewed
Apr 14, 2026
Contributor
rbharath
left a comment
There was a problem hiding this comment.
@shreyasvinaya This PR needs to be split up into smaller PRs. Think about how to factor it down. Another general comment is that individual functions are very long; there is not a clean logic here. This code will become rapidly very hard to maintain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds LLM.py and a helpers.py due to large number of lines addition to one file
Type of change
Please check the option that is related to your PR.
Checklist