Skip to content

llm.py port#199

Open
shreyasvinaya wants to merge 2 commits intomainfrom
llm.py
Open

llm.py port#199
shreyasvinaya wants to merge 2 commits intomainfrom
llm.py

Conversation

@shreyasvinaya
Copy link
Copy Markdown
Collaborator

Description

adds LLM.py and a helpers.py due to large number of lines addition to one file

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@shreyasvinaya shreyasvinaya changed the title llm.py changes llm.py port Apr 14, 2026
Copy link
Copy Markdown
Contributor

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ARY2260 Can you do a round of review?

@shreyasvinaya The API feels like it is passing around a lot of parameters in a way that will be hard to maintain. I will think more about how to improve



@dataclass(frozen=True)
class ModelSelection:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want this data class?

Copy link
Copy Markdown
Contributor

@rbharath rbharath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyasvinaya This PR needs to be split up into smaller PRs. Think about how to factor it down. Another general comment is that individual functions are very long; there is not a clean logic here. This code will become rapidly very hard to maintain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants