Skip to content

Feat: add ligand prep and pdb clean primitives#65

Open
vsaravind01 wants to merge 5 commits intomainfrom
proteomscan/primitives
Open

Feat: add ligand prep and pdb clean primitives#65
vsaravind01 wants to merge 5 commits intomainfrom
proteomscan/primitives

Conversation

@vsaravind01
Copy link
Copy Markdown
Collaborator

Description

Added ligand prep and pdb clean primitives

Type of change

Please check the option that is related to your PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • In this case, we recommend to discuss your modification on GitHub issues before creating the PR
  • Documentations (modification for documents)

Checklist

  • Run lint.sh and ensure that it passes (Use ./lint.sh --fix to fix formatting issues automatically)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@vsaravind01 vsaravind01 force-pushed the proteomscan/primitives branch from 272bcb8 to e5733c7 Compare April 6, 2026 17:08
@vsaravind01 vsaravind01 force-pushed the proteomscan/primitives branch from e5733c7 to cfaae7d Compare April 6, 2026 17:13
@vsaravind01 vsaravind01 requested a review from ARY2260 April 6, 2026 17:14
mol = Chem.AddHs(mol)

log_progress('ligand_prep', 50, 'generating 3D coordinates with ETKDGv3')
params = AllChem.ETKDG() # type: ignore
Copy link
Copy Markdown
Contributor

@riya-singh28 riya-singh28 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you are not using the latest ETKDG version in line 79. In the log progress comment, you have mentioned v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants