Repository navigation
Explore table alignments and adopt their ontology together - #1179
Aschenbath wants to merge 1 commit into
Conversation
Signed-off-by: Nash Aschenbath <wwh86696@163.com>
|
Thank you for this. It follows #554 closely and the write path is sound: one proposal per table, adoption in one transaction with the version check and the schema re-read, and class and property creation made transactional along the way. We ran the wide corpus against a real model (deepseek-v4-flash, thinking off, empty ontology, a new base each run), which the description says is still missing:
So before review:
For the review after that: make the new foreign keys One more thing. Once this lands, nothing reads an adopted alignment until #556. Would you like to take #556 next? If not, we will do it ourselves, so please say either way. #1131 is also still waiting on the split. Thanks again for the work on this. |
Why
Exploration currently creates Metric/Dimension entities and proposes aggregate SQL even though a schema does not contain the business definitions. #554 and ADR 0036 instead ask which class a table represents, which class owns each column, and how a stored value becomes an attribute value.
What changes
mappings.mjs --alignmentsscore table classes, column ownership, relation roles and exclusions. Manual SQL definitions remain available; rendering definitions and retiring the legacy classes stay with Metric and Dimension retire, and a mapping is rendered from an alignment and a rule #556.Migration 0108 leaves 0107 available for the reserved #1097 work; the CLI schema count is 98. The proposal origin is
exploration, keeping schema proposals out of the question agent's outcome statistics.How it was checked
UTOPIA_TEST_REQUIRE_DB=1andUTOPIA_TEST_REQUIRE_PDFTOTEXT=1.Draft for live-model acceptance: the wide corpus has not been run against a real model here. The scripted tests prove the write path, not vocabulary quality or conversion accuracy. The structural scorer uses explicit key alternatives and needs human interpretation for other valid vocabulary. Source DDL is checked before adoption but is not locked across the external database. Editing/reopening a decided alignment, SQL rendering and executing aligned rules are outside this cut.
Refs #554; implements the table-alignment portion of ADR 0036.
Before review