Repository navigation
A base with no properties still queues the ontology agent once enough signatures are unbound - #1336
Conversation
WaylandYang
left a comment
There was a problem hiding this comment.
The logic and the test are right: decide commits per signature, so the count in the early-return branch sees the twenty none rows, and after the delete the fixture really has no properties (known_as is only created lazily by ensure_known_as, which nothing on this path calls). Three house-rule fixes before it can land:
- Base was
main; contributions land ondev(CONTRIBUTING). I have retargeted the PR todev; the three touched files are identical on both branches, so no rebase is needed. - The commit is not signed off (DCO).
git commit --amend -s, and keep the message to one sentence; the body can go. - The revision note and the status line cite #1335, the issue. The earlier notes (#1257, #1288) cite the PR, so this should be #1336.
… signatures are unbound Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Bogdan Szabo <bogdan@re-cinq.com>
21d23bc to
3be559c
Compare
|
Thank you for the review and for retargeting it to |
|
A gentle ping whenever you have a moment, no rush. The sign-off and the #1336 citations are fixed. CI failed on an unrelated chat test ( |
Signed-off-by: Bogdan Szabo <bogdan@re-cinq.com>
d596009 to
4973b34
Compare
WaylandYang
left a comment
There was a problem hiding this comment.
All three points done: base is dev, the commit is one signed-off sentence, and the 0061 note cites #1336. Code and test are unchanged from the reviewed version. Approving; this supersedes the change request.
Sync upstream dev into re-dev (2026-10-22): deeplethe#1336
Hi! This fixes #1335.
When a base has no relation types,
align_phrases_lockeddecided every signaturenoneand returned before thepropose_ontologytrigger, so a base created without packs or an import never got the agent queued on its own. The empty-ontology branch now reaches the same trigger as the normal tail; both call one smallqueue_ontology_agent_if_unbound. Nothing else changes: the threshold, the debounce and the manual Suggest stay as they were.Test first, then the fix:
a_base_with_no_properties_queues_propose_ontology_once_twenty_signatures_are_unboundfailed withpropose_ontology not queued, queued: []and passes now, with the rest of the phrase alignment module (40 tests). ADR 0061 gets a dated revision note.Thank you for taking a look!
Closes #1335
🤖 Generated with Claude Code