Skip to content

A base with no properties still queues the ontology agent once enough signatures are unbound - #1336

Merged
WaylandYang merged 3 commits into
deeplethe:devfrom
re-cinq:fix/empty-ontology-propose-trigger
Oct 22, 2026
Merged

WaylandYang merged 3 commits into
deeplethe:devfrom
re-cinq:fix/empty-ontology-propose-trigger

Conversation

@gedaiu

@gedaiu gedaiu commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Hi! This fixes #1335.

When a base has no relation types, align_phrases_locked decided every signature none and returned before the propose_ontology trigger, so a base created without packs or an import never got the agent queued on its own. The empty-ontology branch now reaches the same trigger as the normal tail; both call one small queue_ontology_agent_if_unbound. Nothing else changes: the threshold, the debounce and the manual Suggest stay as they were.

Test first, then the fix: a_base_with_no_properties_queues_propose_ontology_once_twenty_signatures_are_unbound failed with propose_ontology not queued, queued: [] and passes now, with the rest of the phrase alignment module (40 tests). ADR 0061 gets a dated revision note.

Thank you for taking a look!

Closes #1335

🤖 Generated with Claude Code

@WaylandYang
WaylandYang changed the base branch from main to dev October 21, 2026 05:45

@WaylandYang WaylandYang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic and the test are right: decide commits per signature, so the count in the early-return branch sees the twenty none rows, and after the delete the fixture really has no properties (known_as is only created lazily by ensure_known_as, which nothing on this path calls). Three house-rule fixes before it can land:

  • Base was main; contributions land on dev (CONTRIBUTING). I have retargeted the PR to dev; the three touched files are identical on both branches, so no rebase is needed.
  • The commit is not signed off (DCO). git commit --amend -s, and keep the message to one sentence; the body can go.
  • The revision note and the status line cite #1335, the issue. The earlier notes (#1257, #1288) cite the PR, so this should be #1336.

… signatures are unbound

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Bogdan Szabo <bogdan@re-cinq.com>
@gedaiu
gedaiu force-pushed the fix/empty-ontology-propose-trigger branch from 21d23bc to 3be559c Compare October 21, 2026 08:04
@gedaiu

gedaiu commented Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Thank you for the review and for retargeting it to dev. The commit is now signed off with a one-sentence message, and the revision note and status line cite #1336. Ready for another look whenever you have a moment.

@gedaiu

gedaiu commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

A gentle ping whenever you have a moment, no rush. The sign-off and the #1336 citations are fixed. CI failed on an unrelated chat test (failed_fallback_save_never_reports_done) that passes on its own, so could you rerun the failed jobs? I can't from my side. Thank you!

Signed-off-by: Bogdan Szabo <bogdan@re-cinq.com>
@gedaiu
gedaiu force-pushed the fix/empty-ontology-propose-trigger branch from d596009 to 4973b34 Compare October 22, 2026 06:46

@WaylandYang WaylandYang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All three points done: base is dev, the commit is one signed-off sentence, and the 0061 note cites #1336. Code and test are unchanged from the reviewed version. Approving; this supersedes the change request.

@WaylandYang
WaylandYang merged commit 8a9979f into deeplethe:dev Oct 22, 2026
6 checks passed
gedaiu added a commit to re-cinq/utopia that referenced this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A base with no packs never asks the ontology agent to grow it

2 participants