fix: preserve cloud tickets and per-job log offsets

[njzjz-bot]

Fixes #614

Summary

• preserve Client(ticket=...) when BOHR_TICKET is unset or empty
• apply a non-empty environment ticket as a temporary request-time override without mutating the configured ticket
• track cloud log byte offsets independently for each normalized job ID
• add mocked regression tests for ticket precedence, password-login fallback, and alternating job logs

Validation

• python -m coverage run -p --source=./dpdispatcher -m unittest (169 passed, 42 skipped)
• python -m coverage combine && python -m coverage report (49% total)
• pre-commit run --all-files
• uvx ty check --python /tmp/dpdispatcher-validation-venv/bin/python --python-version 3.13
• dpdisp --help
• python -m dpdispatcher -h
• make html in doc/ (succeeded with existing warnings)
• pyright was attempted, but its local wrapper could not provision a Node runtime; the repository's current ty check passes

Coding agent: Codex
Codex version: codex-cli 0.144.4
Model: gpt-5.6-sol
Reasoning effort: xhigh

Summary by CodeRabbit

• Bug Fixes

  • Improved authentication ticket handling across requests and token refreshes.
  • Environment-provided tickets are now applied consistently when available.
  • Log streaming now tracks progress independently for each job, preventing one job’s completed logs from affecting another.

• Tests

  • Added coverage for ticket selection, login behavior, and independent multi-job log retrieval.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.66%. Comparing base (5d1536c) to head (1b28608).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #623      +/-   ##
==========================================
+ Coverage   57.51%   58.66%   +1.14%     
==========================================
  Files          40       40              
  Lines        4256     4265       +9     
==========================================
+ Hits         2448     2502      +54     
+ Misses       1808     1763      -45     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Warning

Review limit reached

Next included review available in 7 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 30f04c6d-7fad-4684-9fe8-b83fa0ba7e6b

📥 Commits

Reviewing files that changed from the base of the PR and between 0cf24f9 and 1b28608.

📒 Files selected for processing (2)

• dpdispatcher/utils/dpcloudserver/client.py
• tests/test_dpcloudserver_client.py

📝 Walkthrough

Walkthrough

The cloud client centralizes ticket selection, avoids unnecessary login when a ticket is available, and tracks log download offsets independently for each job. New tests cover ticket precedence, password login, request headers, and multi-job log polling.

Changes

Cloud client behavior

Layer / File(s)	Summary
Ticket resolution and login flow dpdispatcher/utils/dpcloudserver/client.py, tests/test_dpcloudserver_client.py	Ticket selection is centralized across request headers and token refresh, with tests for explicit tickets, environment overrides, and password login.
Per-job log offset tracking dpdispatcher/utils/dpcloudserver/client.py, tests/test_dpcloudserver_client.py	Log range requests maintain separate byte offsets per job, with tests covering independent reads and completion state.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main fix: preserving cloud tickets and per-job log offsets.
Linked Issues check	✅ Passed	The changes match #614 by preserving explicit tickets, avoiding unintended login, and tracking log offsets per job.
Out of Scope Changes check	✅ Passed	The PR stays focused on ticket handling and log-offset fixes, with only targeted regression tests added.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@dpdispatcher/utils/dpcloudserver/client.py`:
- Around line 281-286: Update the requests.get call in the log polling method to
pass the established HTTP_TIME_OUT value and validate the response before using
resp.content. Raise or otherwise handle unsuccessful responses so error payloads
are not returned or counted in self.last_log_offsets, and update
request_get.call_args_list test assertions to include the timeout argument.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a0b5cf4d-4e38-451d-9957-39ed3a880e46

📥 Commits

Reviewing files that changed from the base of the PR and between e23bb8c and 0cf24f9.

📒 Files selected for processing (2)

• dpdispatcher/utils/dpcloudserver/client.py
• tests/test_dpcloudserver_client.py

[njzjz-bot]

The ticket preservation and per-job offset split are sound, but one unresolved log-fetch reliability issue remains: failed or unbounded HTTP requests can hang polling and corrupt the new per-job offset. I independently confirmed the existing unresolved thread; the actionable fix is inline.

This PR is authored by the reviewing account, so this is a comment review rather than a self-requested change.

Review context: Codex's quota is close to resetting, so I'm deliberately spending the remaining tokens on reviewing the open PR queue now.

Coding agent: Codex
Codex version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning effort: xhigh

[njzjz-bot]

LGTM. The updated cloud log download now bounds requests, handles request failures, rejects unsuccessful responses, and advances offsets only after a successful fetch. The previous finding is resolved.

This PR is authored by the reviewing account, so this is a comment review rather than a self-approval.

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

[njzjz-bot]

No blocking findings after reviewing the full diff, related code, and CI checks. Intended decision: APPROVE. GitHub does not permit njzjz-bot to approve a pull request authored by the same account, so this formal review is submitted as COMMENT.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

[njzjz-bot]

Reviewed the complete diff and relevant surrounding code. No blocking findings. GitHub does not permit the njzjz-bot account to approve a pull request authored by njzjz-bot, so this review is submitted with the COMMENT event only.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

[njzjz-bot]

Independent review result: no blocking issues found. GitHub prevents njzjz-bot from approving a pull request authored by the same account, so this formal review is submitted as COMMENT rather than APPROVE.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh