fix: avoid shared task and resource collections - #624
Conversation
Replace mutable constructor defaults with fresh collections, detach caller-owned task and resource configuration, and make the cloud zip helper close archives safely. Coding-Agent: Codex Codex-Version: codex-cli 0.144.4 Model: gpt-5.6-sol Reasoning-Effort: xhigh
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #624 +/- ##
==========================================
+ Coverage 48.38% 48.64% +0.26%
==========================================
Files 40 40
Lines 3960 3961 +1
==========================================
+ Hits 1916 1927 +11
+ Misses 2044 2034 -10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
njzjz-bot
left a comment
There was a problem hiding this comment.
Reviewed the constructor and serialization changes. Task/resource collections are detached from defaults and caller-owned containers, nested strategy/env/backend kwargs are copied, deserialization still fills defaults, and the zip helper closes archives reliably. The full CI matrix is green; I found no blocking issue.
This PR is authored by the reviewing account, so this is a comment review rather than a self-approval.
Review context: Codex's quota is close to resetting, so I'm deliberately spending the remaining tokens on reviewing the open PR queue now.
Coding agent: Codex
Codex version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning effort: xhigh
njzjz-bot
left a comment
There was a problem hiding this comment.
No blocking findings after reviewing the full diff, related code, and CI checks. Intended decision: APPROVE. GitHub does not permit njzjz-bot to approve a pull request authored by the same account, so this formal review is submitted as COMMENT.
Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh
njzjz-bot
left a comment
There was a problem hiding this comment.
Reviewed the complete diff and relevant surrounding code. No blocking findings. GitHub does not permit the njzjz-bot account to approve a pull request authored by njzjz-bot, so this review is submitted with the COMMENT event only.
Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh
njzjz-bot
left a comment
There was a problem hiding this comment.
Independent review result: no blocking issues found. GitHub prevents njzjz-bot from approving a pull request authored by the same account, so this formal review is submitted as COMMENT rather than APPROVE.
Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh
Fixes #608
Summary
TaskandResourcesconstructor defaults with fresh collectionsNonedefault and guaranteed archive closureValidation
python -m coverage run -p --source=./dpdispatcher -m unittest(170 passed, 42 skipped)python -m coverage combine && python -m coverage report(47% total)pre-commit run --all-filesuvx ty check dpdispatcher/submission.py dpdispatcher/utils/dpcloudserver/zip_file.py --python /tmp/dpdispatcher-validation-venv/bin/python --python-version 3.13dpdisp --helppython -m dpdispatcher -hmake htmlindoc/(succeeded with existing warnings)pyrightwas attempted, but its local wrapper could not provision a Node runtime; the repository's current changed-filetycheck passesCoding agent: Codex
Codex version: codex-cli 0.144.4
Model: gpt-5.6-sol
Reasoning effort: xhigh