Skip to content

fix: omit empty scheduler resource directives - #636

Open
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/issue-611-optional-directives
Open

fix: omit empty scheduler resource directives#636
njzjz-bot wants to merge 1 commit into
deepmodeling:masterfrom
njzjz-bot:fix/issue-611-optional-directives

Conversation

@njzjz-bot

Copy link
Copy Markdown
Contributor

Summary

  • omit empty queue directives for PBS, Torque, LSF, JH_UniScheduler, and Fugaku
  • omit zero-GPU directives for LSF and JH_UniScheduler
  • preserve explicit custom GPU lines even when the numeric GPU count is zero
  • add scheduler-header regression coverage for default CPU resources

Closes #611

Tests

  • python -m coverage run -p --source=./dpdispatcher -m unittest -v (166 passed, 42 skipped)
  • ruff check .
  • ruff format --check .
  • pyright dpdispatcher/machines/lsf.py dpdispatcher/machines/JH_UniScheduler.py dpdispatcher/machines/fugaku.py dpdispatcher/machines/pbs.py
  • dpdisp --help

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Skip queue and zero-GPU directives while preserving explicit custom GPU lines.

Coding-Agent: Codex
Codex-Version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 58 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cdd32d91-7299-42ca-8589-5a075366ec23

📥 Commits

Reviewing files that changed from the base of the PR and between 34ddb4b and 6d73ea1.

📒 Files selected for processing (5)
  • dpdispatcher/machines/JH_UniScheduler.py
  • dpdispatcher/machines/fugaku.py
  • dpdispatcher/machines/lsf.py
  • dpdispatcher/machines/pbs.py
  • tests/test_optional_scheduler_directives.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.80%. Comparing base (f547911) to head (6d73ea1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
+ Coverage   48.38%   52.80%   +4.41%     
==========================================
  Files          40       40              
  Lines        3960     3962       +2     
==========================================
+ Hits         1916     2092     +176     
+ Misses       2044     1870     -174     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Omit empty queue and zero-GPU scheduler directives

1 participant