Skip to content

docs: honor allow-ref in submit skill commands - #645

Merged
njzjz merged 1 commit into
deepmodeling:masterfrom
njzjz:docs/issue-619-allow-ref-skill
Aug 29, 2026
Merged

docs: honor allow-ref in submit skill commands#645
njzjz merged 1 commit into
deepmodeling:masterfrom
njzjz:docs/issue-619-allow-ref-skill

Conversation

@njzjz

@njzjz njzjz commented Aug 23, 2026

Copy link
Copy Markdown
Member

Summary

  • show separate validation and submission command chains for referenced and non-referenced configurations
  • require the same allow-ref choice during recovery commands
  • move the compatibility prerequisite into the skill body so the skill validator accepts the frontmatter

Closes #619

Validation

  • full unit suite: 163 passed, 42 skipped
  • Codex skill quick validation passed
  • documented dpdisp command help and syntax checks passed
  • pre-commit and Ruff checks passed
  • exact CI ty==0.0.17 check passed

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

Show separate validation and submission command chains for referenced and non-referenced configurations, and require the same choice on recovery. Move the compatibility prerequisite into the skill body so the Codex skill validator accepts the frontmatter.

Coding-Agent: Codex
Codex-Version: codex-cli 0.144.6
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation labels Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a30e886e-9636-4a12-85d7-590cef42646a

📥 Commits

Reviewing files that changed from the base of the PR and between 34ddb4b and 75122c7.

📒 Files selected for processing (1)
  • skills/dpdisp-submit/SKILL.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.38%. Comparing base (f547911) to head (75122c7).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #645   +/-   ##
=======================================
  Coverage   48.38%   48.38%           
=======================================
  Files          40       40           
  Lines        3960     3960           
=======================================
  Hits         1916     1916           
  Misses       2044     2044           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings after reviewing the full diff, related code, and CI checks.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete diff and relevant surrounding code. No blocking findings. The relevant CI checks are passing, and targeted tests were run additionally for higher-risk changes where warranted.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@njzjz-bot njzjz-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review completed. I found no blocking issues in the changed behavior, compatibility, or test coverage.

Coding agent: Codex
Codex version: codex-cli 0.151.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@njzjz
njzjz merged commit e9094e3 into deepmodeling:master Aug 29, 2026
31 checks passed
@njzjz
njzjz deleted the docs/issue-619-allow-ref-skill branch August 29, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Code scan] Make dpdisp-submit skill commands honor --allow-ref

2 participants