Skip to content

fix: hide generated job scripts - #646

Open
njzjz wants to merge 1 commit into
deepmodeling:masterfrom
njzjz:fix/issue-400-hide-job-scripts
Open

fix: hide generated job scripts#646
njzjz wants to merge 1 commit into
deepmodeling:masterfrom
njzjz:fix/issue-400-hide-job-scripts

Conversation

@njzjz

@njzjz njzjz commented Aug 23, 2026

Copy link
Copy Markdown
Member

Summary

  • prefix generated per-job submission and run scripts with a dot so normal directory listings omit dispatcher artifacts
  • preserve the existing work-root layout, job hashes, recovery, resubmission, and scheduler behavior
  • cover scheduler-wide generation, LazyLocal recovery/resubmission, and cloud archive upload paths
  • document the hidden artifact names

Closes #400

Validation

  • full unit suite: 168 passed, 42 skipped
  • focused scheduler, LazyLocal, recovery, resubmission, and cloud tests passed
  • uvx pre-commit run --all-files passed
  • changed-file Pyright passed
  • CLI and documentation builds passed with existing warnings

Repository-wide Pyright retains unrelated baseline diagnostics.

Coding agent: Codex
Codex version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning effort: xhigh

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 57 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b688c0b6-45dd-49f0-b932-be64da870578

📥 Commits

Reviewing files that changed from the base of the PR and between 34ddb4b and a93d1e7.

📒 Files selected for processing (3)
  • doc/getting-started.md
  • dpdispatcher/submission.py
  • tests/test_hidden_job_scripts.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Prefix generated submission and run scripts with a dot so normal directory listings omit dispatcher artifacts while preserving the existing work-root layout and job hashes. Cover scheduler script generation, LazyLocal recovery and resubmission, and cloud archive uploads.

Coding-Agent: Codex
Codex-Version: codex-cli 0.149.0
Model: gpt-5.6-sol
Reasoning-Effort: xhigh
@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.08%. Comparing base (34ddb4b) to head (a93d1e7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   48.38%   51.08%   +2.70%     
==========================================
  Files          40       40              
  Lines        3960     3960              
==========================================
+ Hits         1916     2023     +107     
+ Misses       2044     1937     -107     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@njzjz
njzjz force-pushed the fix/issue-400-hide-job-scripts branch from 46847e8 to a93d1e7 Compare August 23, 2026 19:56
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Aug 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: hide the *.sub and *.run file in some other directory

2 participants