Skip to content

feat(generator): add opt-in exploration recovery - #1984

Open
SchrodingersCattt wants to merge 2 commits into
deepmodeling:masterfrom
SchrodingersCattt:feat/exploration-recovery-1981
Open

SchrodingersCattt wants to merge 2 commits into
deepmodeling:masterfrom
SchrodingersCattt:feat/exploration-recovery-1981

Conversation

@SchrodingersCattt

@SchrodingersCattt SchrodingersCattt commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add opt-in recovery for failed or truncated exploration tasks while keeping task failure status explicit.

Changes

  • Validate dump frames, atom mappings, finite coordinates/forces, and deviation timestep matches.
  • Apply configured task failure budgets.
  • Write exploration_report.json with valid and excluded frames.
  • Feed the valid timestep allow-list into model-deviation selection.
  • Use DPDispatcher partial-result download and non-raising continuation options.

The dispatcher interface dependency is provided by the companion dpdispatcher failed-result policy PR.

Validation

  • Recovery policy, prefix salvage, and selection allow-list tests passed.
  • Python syntax and diff checks passed.

Closes #1981.

Depends on deepmodeling/dpdispatcher#687.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2386767d-2bf8-48a5-ba91-b0752aa0e834

📥 Commits

Reviewing files that changed from the base of the PR and between 0b9acec and 96a72bf.

📒 Files selected for processing (3)
  • dpgen/generator/arginfo.py
  • dpgen/generator/run.py
  • tests/generator/test_model_devi_recovery.py
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.43284% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.98%. Comparing base (0b9acec) to head (96a72bf).

Files with missing lines Patch % Lines
dpgen/generator/run.py 63.15% 49 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1984      +/-   ##
==========================================
+ Coverage   54.91%   54.98%   +0.07%     
==========================================
  Files          84       84              
  Lines       15084    15216     +132     
==========================================
+ Hits         8283     8367      +84     
- Misses       6801     6849      +48     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Native recovery from failed exploration tasks with validated prefix frames and compatible ratio policies

1 participant